Files
react-native/ReactCommon/react/renderer/core/EventDispatcher.cpp
T
Samuel Susla 2669118fc8 Make event coalescing more aggressive
Summary:
Changelog: [internal]

Previous implementation of coalescing would only look at the last element in `eventQueue_` and if it was the same type and target, it would coalesce the two together. This was problem when user would scroll in UIScrollView, this triggers onTouchMove and onScroll events at high rates and prevents coalescing of them.

This changes changes the behaviour to search the `eventQueue_` backwards for an event of the same type and target. If one if found, it is moved into its place. If even of another type is found before for the same target, the event is pushed back onto the queue.

Reviewed By: JoshuaGross

Differential Revision: D24992941

fbshipit-source-id: fc1eae4ecd100af6202346674778b0634ed7a15b
2020-11-17 04:21:01 -08:00

76 lines
2.3 KiB
C++

/*
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#include "EventDispatcher.h"
#include <react/renderer/core/StateUpdate.h>
#include "BatchedEventQueue.h"
#include "RawEvent.h"
#include "UnbatchedEventQueue.h"
namespace facebook {
namespace react {
EventDispatcher::EventDispatcher(
EventPipe const &eventPipe,
StatePipe const &statePipe,
EventBeat::Factory const &synchonousEventBeatFactory,
EventBeat::Factory const &asynchonousEventBeatFactory,
EventBeat::SharedOwnerBox const &ownerBox,
bool enableV2EventCoalescing)
: synchronousUnbatchedQueue_(std::make_unique<UnbatchedEventQueue>(
eventPipe,
statePipe,
synchonousEventBeatFactory(ownerBox))),
synchronousBatchedQueue_(std::make_unique<BatchedEventQueue>(
eventPipe,
statePipe,
synchonousEventBeatFactory(ownerBox),
enableV2EventCoalescing)),
asynchronousUnbatchedQueue_(std::make_unique<UnbatchedEventQueue>(
eventPipe,
statePipe,
asynchonousEventBeatFactory(ownerBox))),
asynchronousBatchedQueue_(std::make_unique<BatchedEventQueue>(
eventPipe,
statePipe,
asynchonousEventBeatFactory(ownerBox),
enableV2EventCoalescing)) {}
void EventDispatcher::dispatchEvent(
RawEvent const &rawEvent,
EventPriority priority) const {
getEventQueue(priority).enqueueEvent(std::move(rawEvent));
}
void EventDispatcher::dispatchStateUpdate(
StateUpdate &&stateUpdate,
EventPriority priority) const {
getEventQueue(priority).enqueueStateUpdate(std::move(stateUpdate));
}
void EventDispatcher::dispatchUniqueEvent(RawEvent const &rawEvent) const {
asynchronousBatchedQueue_->enqueueUniqueEvent(rawEvent);
}
const EventQueue &EventDispatcher::getEventQueue(EventPriority priority) const {
switch (priority) {
case EventPriority::SynchronousUnbatched:
return *synchronousUnbatchedQueue_;
case EventPriority::SynchronousBatched:
return *synchronousBatchedQueue_;
case EventPriority::AsynchronousUnbatched:
return *asynchronousUnbatchedQueue_;
case EventPriority::AsynchronousBatched:
return *asynchronousBatchedQueue_;
}
}
} // namespace react
} // namespace facebook