mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Valentin Shergin
5c4979b2a5
Summary: This change introducing using `updateStateWithAutorepeat` for state updates in RCTSafeAreaViewComponentView. This way we can reduce the number of active commits and reduce jumps & relayout passes. The approach with a callback is better than using `_lastPaddingStateWasUpdatedWith` because: * When we compare the values, we can compare them with actual previous padding numbers stored in Shadow Tree. * The value stored in a UIView instance can go away because of a view being remounted because of flattening. Changelog: [Internal] Fabric-specific internal change. Reviewed By: JoshuaGross Differential Revision: D24719345 fbshipit-source-id: 9bf1ae284875b4c99cf23be2fcc9a829eb8a895e
113 lines
3.0 KiB
Plaintext
113 lines
3.0 KiB
Plaintext
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import "RCTSafeAreaViewComponentView.h"
|
|
|
|
#import <React/RCTUtils.h>
|
|
#import <react/renderer/components/safeareaview/SafeAreaViewComponentDescriptor.h>
|
|
#import <react/renderer/components/safeareaview/SafeAreaViewState.h>
|
|
#import "FBRCTFabricComponentsPlugins.h"
|
|
#import "RCTConversions.h"
|
|
#import "RCTFabricComponentsPlugins.h"
|
|
|
|
using namespace facebook::react;
|
|
|
|
@implementation RCTSafeAreaViewComponentView {
|
|
SafeAreaViewShadowNode::ConcreteState::Shared _state;
|
|
}
|
|
|
|
- (instancetype)initWithFrame:(CGRect)frame
|
|
{
|
|
if (self = [super initWithFrame:frame]) {
|
|
static auto const defaultProps = std::make_shared<SafeAreaViewProps const>();
|
|
_props = defaultProps;
|
|
self.clipsToBounds = YES;
|
|
}
|
|
|
|
return self;
|
|
}
|
|
|
|
- (UIEdgeInsets)_safeAreaInsets
|
|
{
|
|
if (@available(iOS 11.0, *)) {
|
|
return self.safeAreaInsets;
|
|
}
|
|
|
|
return UIEdgeInsetsZero;
|
|
}
|
|
|
|
- (void)safeAreaInsetsDidChange
|
|
{
|
|
[super safeAreaInsetsDidChange];
|
|
|
|
[self _updateStateIfNecessary];
|
|
}
|
|
|
|
- (void)_updateStateIfNecessary
|
|
{
|
|
if (!_state) {
|
|
return;
|
|
}
|
|
|
|
UIEdgeInsets insets = [self _safeAreaInsets];
|
|
insets.left = RCTRoundPixelValue(insets.left);
|
|
insets.top = RCTRoundPixelValue(insets.top);
|
|
insets.right = RCTRoundPixelValue(insets.right);
|
|
insets.bottom = RCTRoundPixelValue(insets.bottom);
|
|
|
|
auto newPadding = RCTEdgeInsetsFromUIEdgeInsets(insets);
|
|
auto threshold = 1.0 / RCTScreenScale() + 0.01; // Size of a pixel plus some small threshold.
|
|
|
|
_state->updateStateWithAutorepeat(
|
|
[=](SafeAreaViewShadowNode::ConcreteState::Data const &oldData)
|
|
-> SafeAreaViewShadowNode::ConcreteState::SharedData {
|
|
auto oldPadding = oldData.padding;
|
|
auto deltaPadding = newPadding - oldPadding;
|
|
|
|
if (std::abs(deltaPadding.left) < threshold && std::abs(deltaPadding.top) < threshold &&
|
|
std::abs(deltaPadding.right) < threshold && std::abs(deltaPadding.bottom) < threshold) {
|
|
return nullptr;
|
|
}
|
|
|
|
auto newData = oldData;
|
|
newData.padding = newPadding;
|
|
return std::make_shared<SafeAreaViewShadowNode::ConcreteState::Data>(newData);
|
|
});
|
|
}
|
|
|
|
#pragma mark - RCTComponentViewProtocol
|
|
|
|
+ (ComponentDescriptorProvider)componentDescriptorProvider
|
|
{
|
|
return concreteComponentDescriptorProvider<SafeAreaViewComponentDescriptor>();
|
|
}
|
|
|
|
- (void)updateState:(facebook::react::State::Shared const &)state
|
|
oldState:(facebook::react::State::Shared const &)oldState
|
|
{
|
|
_state = std::static_pointer_cast<SafeAreaViewShadowNode::ConcreteState const>(state);
|
|
}
|
|
|
|
- (void)finalizeUpdates:(RNComponentViewUpdateMask)updateMask
|
|
{
|
|
[super finalizeUpdates:updateMask];
|
|
[self _updateStateIfNecessary];
|
|
}
|
|
|
|
- (void)prepareForRecycle
|
|
{
|
|
[super prepareForRecycle];
|
|
_state.reset();
|
|
}
|
|
|
|
@end
|
|
|
|
Class<RCTComponentViewProtocol> RCTSafeAreaViewCls(void)
|
|
{
|
|
return RCTSafeAreaViewComponentView.class;
|
|
}
|