mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
James Treanor
8131b7bb7b
Summary: This is my proposal for fixing `use_frameworks!` compatibility without breaking all `<React/*>` imports I outlined in https://github.com/facebook/react-native/pull/25393#issuecomment-508457700. If accepted, it will fix https://github.com/facebook/react-native/issues/25349. It builds on the changes I made in https://github.com/facebook/react-native/pull/25496 by ensuring each podspec has a unique value for `header_dir` so that framework imports do not conflict. Every podspec which should be included in the `<React/*>` namespace now includes it's headers from `React-Core.podspec`. The following pods can still be imported with `<React/*>` and so should not have breaking changes: `React-ART`,`React-DevSupport`, `React-CoreModules`, `React-RCTActionSheet`, `React-RCTAnimation`, `React-RCTBlob`, `React-RCTImage`, `React-RCTLinking`, `React-RCTNetwork`, `React-RCTPushNotification`, `React-RCTSettings`, `React-RCTText`, `React-RCTSettings`, `React-RCTVibration`, `React-RCTWebSocket` . There are still a few breaking changes which I hope will be acceptable: - `React-Core.podspec` has been moved to the root of the project. Any `Podfile` that references it will need to update the path. - ~~`React-turbomodule-core`'s headers now live under `<turbomodule/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823. - ~~`React-turbomodulesamples`'s headers now live under `<turbomodulesamples/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823. - ~~`React-TypeSaferty`'s headers now live under `<TypeSafety/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511040967. - ~~`React-jscallinvoker`'s headers now live under `<jscallinvoker/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823. - Each podspec now uses `s.static_framework = true`. This means that a minimum of CocoaPods 1.5 ([released in April 2018](http://blog.cocoapods.org/CocoaPods-1.5.0/)) is now required. This is needed so that the ` __has_include` conditions can still work when frameworks are enabled. Still to do: - ~~Including `React-turbomodule-core` with `use_frameworks!` enabled causes the C++ import failures we saw in https://github.com/facebook/react-native/issues/25349. I'm sure it will be possible to fix this but I need to dig deeper (perhaps a custom modulemap would be needed).~~ Addressed by https://github.com/facebook/react-native/pull/25619/commits/33573511f02f3502a28bad48e085e9a4b8608302. - I haven't got Fabric working yet. I wonder if it would be acceptable to move Fabric out of the `<React/*>` namespace since it is new? � ## Changelog [iOS] [Fixed] - Fixed compatibility with CocoaPods frameworks. Pull Request resolved: https://github.com/facebook/react-native/pull/25619 Test Plan: ### FB ``` buck build catalyst ``` ### Sample Project Everything should work exactly as before, where `use_frameworks!` is not in `Podfile`s. I have a branch on my [sample project](https://github.com/jtreanor/react-native-cocoapods-frameworks) here which has `use_frameworks!` in its `Podfile` to demonstrate this is fixed. You can see that it works with these steps: 1. `git clone git@github.com:jtreanor/react-native-cocoapods-frameworks.git` 2. `git checkout fix-frameworks-subspecs` 3. `cd ios && pod install` 4. `cd .. && react-native run-ios` The sample app will build and run successfully. To see that it still works without frameworks, remove `use_frameworks!` from the `Podfile` and do steps 3 and 4 again. ### RNTesterPods `RNTesterPodsPods` can now work with or without `use_frameworks!`. 1. Go to the `RNTester` directory and run `pod install`. 2. Run the tests in `RNTesterPods.xcworkspace` to see that everything still works fine. 3. Uncomment the `use_frameworks!` line at the top of `RNTester/Podfile` and run `pod install` again. 4. Run the tests again and see that it still works with frameworks enabled. Reviewed By: PeteTheHeat Differential Revision: D16465247 Pulled By: PeteTheHeat fbshipit-source-id: cad837e9cced06d30cc5b372af1c65c7780b9e7a
170 lines
6.2 KiB
JSON
170 lines
6.2 KiB
JSON
{
|
|
"name": "react-native",
|
|
"version": "1000.0.0",
|
|
"bin": "./cli.js",
|
|
"description": "A framework for building native apps using React",
|
|
"license": "MIT",
|
|
"repository": {
|
|
"type": "git",
|
|
"url": "git@github.com:facebook/react-native.git"
|
|
},
|
|
"engines": {
|
|
"node": ">=8.3"
|
|
},
|
|
"jest-junit": {
|
|
"outputDirectory": "reports/junit",
|
|
"outputName": "js-test-results.xml"
|
|
},
|
|
"main": "Libraries/react-native/react-native-implementation.js",
|
|
"files": [
|
|
".flowconfig",
|
|
"android",
|
|
"cli.js",
|
|
"flow",
|
|
"init.sh",
|
|
"scripts/ios-configure-glog.sh",
|
|
"scripts/ios-install-third-party.sh",
|
|
"scripts/launchPackager.bat",
|
|
"scripts/launchPackager.command",
|
|
"scripts/packager.sh",
|
|
"scripts/react-native-xcode.sh",
|
|
"scripts/node-binary.sh",
|
|
"jest-preset.js",
|
|
"jest",
|
|
"lib",
|
|
"rn-get-polyfills.js",
|
|
"Libraries",
|
|
"LICENSE",
|
|
"packager",
|
|
"react-native.config.js",
|
|
"react.gradle",
|
|
"React.podspec",
|
|
"React-Core.podspec",
|
|
"React",
|
|
"ReactAndroid",
|
|
"ReactCommon",
|
|
"README.md",
|
|
"third-party-podspecs",
|
|
"template",
|
|
"local-cli",
|
|
"template.config.js",
|
|
"!template/node_modules",
|
|
"!template/yarn.lock",
|
|
"!template/package-lock.json"
|
|
],
|
|
"scripts": {
|
|
"start": "react-native start",
|
|
"test": "jest",
|
|
"test-ci": "jest --maxWorkers=2 --ci --reporters=\"default\" --reporters=\"jest-junit\"",
|
|
"flow": "flow",
|
|
"flow-check-ios": "flow check",
|
|
"flow-check-android": "flow check --flowconfig-name .flowconfig.android",
|
|
"lint": "eslint .",
|
|
"lint-ci": "./scripts/circleci/analyze_code.sh && yarn shellcheck",
|
|
"shellcheck": "./scripts/circleci/analyze_scripts.sh",
|
|
"clang-format": "clang-format -i --glob=*/**/*.{h,cpp,m,mm}",
|
|
"format": "npm run prettier && npm run clang-format",
|
|
"prettier": "prettier --write \"./**/*.{js,md,yml}\"",
|
|
"format-check": "prettier --list-different \"./**/*.{js,md,yml}\"",
|
|
"docker-setup-android": "docker pull reactnativecommunity/react-native-android",
|
|
"docker-build-android": "docker build -t reactnativeci/android -f .circleci/Dockerfiles/Dockerfile.android .",
|
|
"test-android-run-instrumentation": "docker run --cap-add=SYS_ADMIN -it reactnativeci/android bash .circleci/Dockerfiles/scripts/run-android-docker-instrumentation-tests.sh",
|
|
"test-android-run-unit": "docker run --cap-add=SYS_ADMIN -it reactnativeci/android bash .circleci/Dockerfiles/scripts/run-android-docker-unit-tests.sh",
|
|
"test-android-run-e2e": "docker run --privileged -it reactnativeci/android bash .circleci/Dockerfiles/scripts/run-ci-e2e-tests.sh --android --js",
|
|
"test-android-all": "yarn run docker-build-android && yarn run test-android-run-unit && yarn run test-android-run-instrumentation && yarn run test-android-run-e2e",
|
|
"test-android-instrumentation": "yarn run docker-build-android && yarn run test-android-run-instrumentation",
|
|
"test-android-unit": "yarn run docker-build-android && yarn run test-android-run-unit",
|
|
"test-android-e2e": "yarn run docker-build-android && yarn run test-android-run-e2e",
|
|
"build-ios-e2e": "detox build -c ios.sim.release",
|
|
"test-ios-e2e": "detox test -c ios.sim.release RNTester/e2e",
|
|
"test-ios": "./scripts/objc-test.sh test"
|
|
},
|
|
"peerDependencies": {
|
|
"react": "16.8.6"
|
|
},
|
|
"dependencies": {
|
|
"@babel/runtime": "^7.0.0",
|
|
"@react-native-community/cli": "^2.6.0",
|
|
"@react-native-community/cli-platform-android": "^2.6.0",
|
|
"@react-native-community/cli-platform-ios": "^2.4.1",
|
|
"abort-controller": "^3.0.0",
|
|
"art": "^0.10.0",
|
|
"base64-js": "^1.1.2",
|
|
"connect": "^3.6.5",
|
|
"create-react-class": "^15.6.3",
|
|
"escape-string-regexp": "^1.0.5",
|
|
"event-target-shim": "^5.0.1",
|
|
"fbjs": "^1.0.0",
|
|
"fbjs-scripts": "^1.1.0",
|
|
"invariant": "^2.2.4",
|
|
"jsc-android": "^245459.0.0",
|
|
"metro-babel-register": "0.54.1",
|
|
"metro-react-native-babel-transformer": "0.54.1",
|
|
"nullthrows": "^1.1.0",
|
|
"pretty-format": "^24.7.0",
|
|
"promise": "^7.1.1",
|
|
"prop-types": "^15.7.2",
|
|
"react-devtools-core": "^3.6.2",
|
|
"react-refresh": "^0.3.0",
|
|
"regenerator-runtime": "^0.13.2",
|
|
"scheduler": "0.14.0",
|
|
"stacktrace-parser": "^0.1.3",
|
|
"whatwg-fetch": "^3.0.0"
|
|
},
|
|
"devDependencies": {
|
|
"@babel/core": "^7.0.0",
|
|
"@babel/generator": "^7.0.0",
|
|
"@react-native-community/eslint-plugin": "1.0.0",
|
|
"@reactions/component": "^2.0.2",
|
|
"async": "^2.4.0",
|
|
"babel-eslint": "10.0.1",
|
|
"clang-format": "^1.2.4",
|
|
"coveralls": "^3.0.2",
|
|
"detox": "12.2.0",
|
|
"eslint": "5.1.0",
|
|
"eslint-config-fb-strict": "24.3.0",
|
|
"eslint-config-fbjs": "2.1.0",
|
|
"eslint-plugin-babel": "^5.3.0",
|
|
"eslint-plugin-eslint-comments": "^3.1.1",
|
|
"eslint-plugin-flowtype": "2.50.3",
|
|
"eslint-plugin-jest": "22.4.1",
|
|
"eslint-plugin-jsx-a11y": "6.2.1",
|
|
"eslint-plugin-prettier": "2.6.2",
|
|
"eslint-plugin-react": "7.12.4",
|
|
"eslint-plugin-react-hooks": "^1.5.1",
|
|
"eslint-plugin-react-native": "3.6.0",
|
|
"eslint-plugin-relay": "1.3.0",
|
|
"flow-bin": "^0.103.0",
|
|
"flow-remove-types": "1.2.3",
|
|
"jest": "^24.7.1",
|
|
"jest-junit": "^6.3.0",
|
|
"jscodeshift": "^0.6.2",
|
|
"mkdirp": "^0.5.1",
|
|
"prettier": "1.17.0",
|
|
"react": "16.8.6",
|
|
"react-test-renderer": "16.8.6",
|
|
"shelljs": "^0.7.8",
|
|
"ws": "^6.1.4",
|
|
"yargs": "^9.0.0"
|
|
},
|
|
"detox": {
|
|
"test-runner": "jest",
|
|
"runner-config": "RNTester/e2e/config.json",
|
|
"specs": "",
|
|
"configurations": {
|
|
"ios.sim.release": {
|
|
"binaryPath": "RNTester/build/Build/Products/Release-iphonesimulator/RNTester.app/",
|
|
"build": "xcodebuild -workspace RNTester/RNTesterPods.xcworkspace -scheme RNTester -configuration Release -sdk iphonesimulator -derivedDataPath RNTester/build -UseModernBuildSystem=NO -quiet",
|
|
"type": "ios.simulator",
|
|
"name": "iPhone 6s"
|
|
},
|
|
"ios.sim.debug": {
|
|
"binaryPath": "RNTester/build/Build/Products/Debug-iphonesimulator/RNTester.app/",
|
|
"build": "xcodebuild -workspace RNTester/RNTesterPods.xcworkspace -scheme RNTester -configuration Debug -sdk iphonesimulator -derivedDataPath RNTester/build -UseModernBuildSystem=NO -quiet",
|
|
"type": "ios.simulator",
|
|
"name": "iPhone 6s"
|
|
}
|
|
}
|
|
}
|
|
}
|