mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
evelant
58adc5e4b9
Summary: Fix build failure on iOS with pnpm and use_frameworks! due to cocoapods copying symlinked headers to wrong paths When using pnpm all packages are symlinked to node_modules/.pnpm to prevent phantom dependency resolution. This causes react-native iOS build to fail because Cocoapods copies headers to incorrect destinations when they're behind symlinks. The fix resolves absolute paths to the header_mappings_dir at pod install time. With absolute paths cocoapods copies the headers correctly. This commit also adds a few missing header search paths in use_frameworks! mode. Fixes https://github.com/facebook/react-native/issues/38140 ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [IOS] [FIXED] - Build failure with pnpm and use_frameworks! due to incorrect header paths For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: https://github.com/facebook/react-native/pull/38158 Test Plan: 1. `pnpm pnpx react-native@latest init AwesomeProject` 2. `cd AwesomeProject` 3. `rm -rf node_modules yarn.lock` 4. `mkdir patches` 5. copy [react-native@0.72.1.patch](https://github.com/facebook/react-native/files/11937570/react-native%400.72.1.patch) to `patches/` 6. Add patch to package.json ``` "pnpm": { "patchedDependencies": { "react-native@0.72.1": "patches/react-native@0.72.1.patch" } } ``` 7. `pnpm install` 8. `cd ios` 9. `NO_FLIPPER=1 USE_FRAMEWORKS=static pod install` 10. `cd ..` 11. `pnpm react-native run-ios` Hopefully an automated test of building with `pnpm` can be added to CI. I don't know how to make that happen, hopefully someone at facebook can do it. Reviewed By: dmytrorykun Differential Revision: D47211946 Pulled By: cipolleschi fbshipit-source-id: 87640bd3f32f023c43291213b5291a7b990d7e1f
63 lines
2.5 KiB
Ruby
63 lines
2.5 KiB
Ruby
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
||
#
|
||
# This source code is licensed under the MIT license found in the
|
||
# LICENSE file in the root directory of this source tree.
|
||
|
||
require "json"
|
||
|
||
package = JSON.parse(File.read(File.join(__dir__, "..", "package.json")))
|
||
version = package['version']
|
||
|
||
source = { :git => 'https://github.com/facebook/react-native.git' }
|
||
if version == '1000.0.0'
|
||
# This is an unpublished version, use the latest commit hash of the react-native repo, which we’re presumably in.
|
||
source[:commit] = `git rev-parse HEAD`.strip if system("git rev-parse --git-dir > /dev/null 2>&1")
|
||
else
|
||
source[:tag] = "v#{version}"
|
||
end
|
||
|
||
# We are using two different paths for react native because of the way how js_srcs_dir and output_dir options are used
|
||
# output_dir option usage was introduced in https://github.com/facebook/react-native/pull/36210
|
||
# React-rncore.podspec is the only podspec in the project that uses this option
|
||
# We should rethink this approach in T148704916
|
||
|
||
# Relative path to react native from iOS project root (e.g. <ios-project-root>/../node_modules/react-native)
|
||
react_native_dependency_path = ENV['REACT_NATIVE_PATH']
|
||
# Relative path to react native from current podspec
|
||
react_native_sources_path = '..'
|
||
|
||
header_search_paths = [
|
||
"\"$(PODS_TARGET_SRCROOT)\"",
|
||
"\"$(PODS_TARGET_SRCROOT)/ReactCommon\"",
|
||
]
|
||
|
||
if ENV["USE_FRAMEWORKS"]
|
||
header_search_paths = header_search_paths.concat([
|
||
"\"$(PODS_CONFIGURATION_BUILD_DIR)/ReactCommon/ReactCommon.framework/Headers/react/nativemodule/core\"",
|
||
])
|
||
end
|
||
|
||
Pod::Spec.new do |s|
|
||
s.name = "React-rncore"
|
||
s.version = version
|
||
s.summary = "Fabric for React Native."
|
||
s.homepage = "https://reactnative.dev/"
|
||
s.license = package["license"]
|
||
s.author = "Meta Platforms, Inc. and its affiliates"
|
||
s.platforms = { :ios => min_ios_version_supported }
|
||
s.source = source
|
||
s.source_files = "dummyFile.cpp"
|
||
s.pod_target_xcconfig = { "USE_HEADERMAP" => "YES",
|
||
"HEADER_SEARCH_PATHS" => header_search_paths.join(' '),
|
||
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17" }
|
||
|
||
|
||
use_react_native_codegen!(s, {
|
||
:react_native_path => react_native_sources_path,
|
||
:js_srcs_dir => "#{react_native_sources_path}/Libraries",
|
||
:library_name => "rncore",
|
||
:library_type => "components",
|
||
:output_dir => "#{react_native_dependency_path}/ReactCommon"
|
||
})
|
||
end
|