mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
empyrical
f312e5ba84
Summary: Original PR contents: This pull request updates the Podspecs and associated build scripts, and some source files so they build on OSS. RNTester now compiles with `fabric_enabled` again. The following changes have been made: * Various spots that were pointing to the old `ReactCommon/fabric` location have now been updated to `ReactCommon/react/renderer` * Files that were attempting to use internal FB header `FBRCTFabricComponentsPlugins.h` were changed to use `RCTFabricComponentsPlugins.h` * `RCTFabricComponentsPlugins` in OSS was updated to include the `Image` fabric component (thanks tsapeta) * Replaced old `generate-rncore.sh` build script with new `generate-rncore.js` script which does not require `flow-node` and uses the `react-native-codegen` API directly, so there is no longer any need for an interim `schema-rncore.json` file. * Updated Yoga podspec which wasn't fully synced with changes from the main Yoga repo * Updated Fabric podspec with additional needed subspecs Additions to PR by hramos: * Replaced use of generate-rncore scripts with the original generate-native-modules-specs.sh script, which is now generate-specs.sh and supports both codegen for Native Modules and Components now (TurboModules/Fabric). * Codegen now runs at build time as part of the Xcode build pipeline instead of as part of `pod install`. The build script is injected by the FBReactNativeSpec pod, as the pod is part of both Fabric and non-Fabric builds. ## Changelog [General] [Fixed] - RNTester compiles with `fabric_enabled` again Pull Request resolved: https://github.com/facebook/react-native/pull/29810 Test Plan: RNTester now compiles and runs in the simulator again when `fabric_enabled` is set to `true`. ``` cd xplat/js/react-native-github/packages/rn-tester USE_FABRIC=1 pod install open RNTesterPods.xcworkspace # Build and run ``` Reviewed By: fkgozali Differential Revision: D24058507 Pulled By: hramos fbshipit-source-id: 8b2ea3694e6cb9aa23f83f087e2995fd4320e2bb
103 lines
2.5 KiB
JavaScript
103 lines
2.5 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
let RNCodegen;
|
|
try {
|
|
RNCodegen = require('react-native-codegen/lib/generators/RNCodegen.js');
|
|
} catch (e) {
|
|
RNCodegen = require('../packages/react-native-codegen/lib/generators/RNCodegen.js');
|
|
if (!RNCodegen) {
|
|
throw 'RNCodegen not found.';
|
|
}
|
|
}
|
|
|
|
const fs = require('fs');
|
|
const mkdirp = require('mkdirp');
|
|
const path = require('path');
|
|
|
|
const GENERATORS = {
|
|
android: ['componentsAndroid', 'modulesAndroid'],
|
|
ios: ['componentsIOS', 'modulesIOS'],
|
|
};
|
|
|
|
function generateSpec(
|
|
platform,
|
|
schemaPath,
|
|
outputDirectory,
|
|
libraryName,
|
|
packageName,
|
|
) {
|
|
const moduleSpecName = libraryName;
|
|
const schemaText = fs.readFileSync(schemaPath, 'utf-8');
|
|
|
|
if (schemaText == null) {
|
|
throw new Error(`Can't find schema at ${schemaPath}`);
|
|
}
|
|
|
|
if (!outputDirectory) {
|
|
outputDirectory = path.resolve(
|
|
__dirname,
|
|
'..',
|
|
'Libraries',
|
|
libraryName,
|
|
moduleSpecName,
|
|
);
|
|
}
|
|
mkdirp.sync(outputDirectory);
|
|
|
|
let schema;
|
|
try {
|
|
schema = JSON.parse(schemaText);
|
|
} catch (err) {
|
|
throw new Error(`Can't parse schema to JSON. ${schemaPath}`);
|
|
}
|
|
|
|
RNCodegen.generate(
|
|
{
|
|
libraryName,
|
|
schema,
|
|
outputDirectory,
|
|
moduleSpecName,
|
|
packageName,
|
|
},
|
|
{
|
|
generators: GENERATORS[platform],
|
|
},
|
|
);
|
|
|
|
if (platform === 'android') {
|
|
// Move all components C++ files to a structured jni folder for now.
|
|
// Note: this should've been done by RNCodegen's generators, but:
|
|
// * the generators don't support platform option yet
|
|
// * this subdir structure is Android-only, not applicable to iOS
|
|
const files = fs.readdirSync(outputDirectory);
|
|
const jniOutputDirectory = `${outputDirectory}/jni/react/renderer/components/${libraryName}`;
|
|
mkdirp.sync(jniOutputDirectory);
|
|
files
|
|
.filter(f => f.endsWith('.h') || f.endsWith('.cpp'))
|
|
.forEach(f => {
|
|
fs.renameSync(`${outputDirectory}/${f}`, `${jniOutputDirectory}/${f}`);
|
|
});
|
|
}
|
|
}
|
|
|
|
function main() {
|
|
const args = process.argv.slice(2);
|
|
const platform = args[0];
|
|
const schemaPath = args[1];
|
|
const outputDir = args[2];
|
|
const libraryName = args[3] || 'FBReactNativeSpec';
|
|
const javaPackageName = args[4] || 'com.facebook.fbreact.specs';
|
|
generateSpec(platform, schemaPath, outputDir, libraryName, javaPackageName);
|
|
}
|
|
|
|
main();
|