Files
react-native/ReactCommon/react/renderer/core/LayoutableShadowNode.cpp
T
Nick Gerleman c2a089fddf Better ShadowNode memory safety (#36258)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/36258

This fixes a few instances where YogaLayoutableShadowNode (or general shadownode casting) could offer better memory safety.

1. The reference form of traitCast() now terminates on invalid cast, instead of debug assert, since it is better to crash in production than to corrupt memory (which will crash somewhere later, in a much more confusing way).
2. We use traitCast() in more places where we previously would static_cast. This means needing to formally add a mutable version.
3. We bounds-check yoga children access in a single place by using `std::vector` `at()` instead of `[]`.
4. Removed `Trait::UnreservedTrait1` API, since multiple libraries using it can collide and we lose the memory safety benefits of `traitCast`.

This change is in response to a bug where `YogaLayoutableShadowNode` may perform an invalid `static_cast` of `RawTextShadowNode` if a text or number is rendered directly inside of a `<View>` (instead of a `<Text>` element).

This does not yet fix the underlying logic of YogaLayoutableShadowNode to act gracefully when a RawTextShadowNode makes its way into children. We just terminate, instead of corrupting memory.

Changelog:
[General][Breaking] -  Better Fabric ShadowNode Memory Safety (Removes `Trait::UnreservedTrait` API)

Reviewed By: javache

Differential Revision: D43271779

fbshipit-source-id: 727c1230f72664bf4d261871c66ca61ddf0d5ffa
2023-02-27 10:07:51 -08:00

373 lines
12 KiB
C++

/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#include "LayoutableShadowNode.h"
#include <react/renderer/core/LayoutConstraints.h>
#include <react/renderer/core/LayoutContext.h>
#include <react/renderer/core/LayoutMetrics.h>
#include <react/renderer/core/ShadowNode.h>
#include <react/renderer/core/TraitCast.h>
#include <react/renderer/debug/DebugStringConvertibleItem.h>
#include <react/renderer/graphics/conversions.h>
namespace facebook::react {
template <class T>
using LayoutableSmallVector = butter::small_vector<T, 16>;
static LayoutableSmallVector<Rect> calculateTransformedFrames(
LayoutableSmallVector<ShadowNode const *> const &shadowNodeList,
LayoutableShadowNode::LayoutInspectingPolicy policy) {
auto size = shadowNodeList.size();
auto transformedFrames = LayoutableSmallVector<Rect>{size};
auto transformation = Transform::Identity();
for (auto i = size; i > 0; --i) {
auto currentShadowNode =
traitCast<LayoutableShadowNode const *>(shadowNodeList.at(i - 1));
auto currentFrame = currentShadowNode->getLayoutMetrics().frame;
if (policy.includeTransform) {
if (Transform::isVerticalInversion(transformation)) {
auto parentShadowNode =
traitCast<LayoutableShadowNode const *>(shadowNodeList.at(i));
currentFrame.origin.y =
parentShadowNode->getLayoutMetrics().frame.size.height -
currentFrame.size.height - currentFrame.origin.y;
}
if (Transform::isHorizontalInversion(transformation)) {
auto parentShadowNode =
traitCast<LayoutableShadowNode const *>(shadowNodeList.at(i));
currentFrame.origin.x =
parentShadowNode->getLayoutMetrics().frame.size.width -
currentFrame.size.width - currentFrame.origin.x;
}
if (i != size) {
auto parentShadowNode =
traitCast<LayoutableShadowNode const *>(shadowNodeList.at(i));
auto contentOritinOffset = parentShadowNode->getContentOriginOffset();
if (Transform::isVerticalInversion(transformation)) {
contentOritinOffset.y = -contentOritinOffset.y;
}
if (Transform::isHorizontalInversion(transformation)) {
contentOritinOffset.x = -contentOritinOffset.x;
}
currentFrame.origin += contentOritinOffset;
}
transformation = transformation * currentShadowNode->getTransform();
}
transformedFrames[i - 1] = currentFrame;
}
return transformedFrames;
}
LayoutableShadowNode::LayoutableShadowNode(
ShadowNodeFragment const &fragment,
ShadowNodeFamily::Shared const &family,
ShadowNodeTraits traits)
: ShadowNode(fragment, family, traits), layoutMetrics_({}) {}
LayoutableShadowNode::LayoutableShadowNode(
ShadowNode const &sourceShadowNode,
ShadowNodeFragment const &fragment)
: ShadowNode(sourceShadowNode, fragment),
layoutMetrics_(static_cast<LayoutableShadowNode const &>(sourceShadowNode)
.layoutMetrics_) {}
LayoutMetrics LayoutableShadowNode::computeRelativeLayoutMetrics(
ShadowNodeFamily const &descendantNodeFamily,
LayoutableShadowNode const &ancestorNode,
LayoutInspectingPolicy policy) {
// Prelude.
if (&descendantNodeFamily == &ancestorNode.getFamily()) {
// Layout metrics of a node computed relatively to the same node are equal
// to `transform`-ed layout metrics of the node with zero `origin`.
auto layoutMetrics = ancestorNode.getLayoutMetrics();
if (layoutMetrics.displayType == DisplayType::None) {
return EmptyLayoutMetrics;
}
if (policy.includeTransform) {
layoutMetrics.frame = layoutMetrics.frame * ancestorNode.getTransform();
}
layoutMetrics.frame.origin = {0, 0};
return layoutMetrics;
}
auto ancestors = descendantNodeFamily.getAncestors(ancestorNode);
if (ancestors.empty()) {
// Specified nodes do not form an ancestor-descender relationship
// in the same tree. Aborting.
return EmptyLayoutMetrics;
}
// ------------------------------
// Step 1.
// Creating a list of nodes that form a chain from the descender node to
// ancestor node inclusively.
auto shadowNodeList = LayoutableSmallVector<ShadowNode const *>{};
// Finding the measured node.
// The last element in the `AncestorList` is a pair of a parent of the node
// and an index of this node in the parent's children list.
auto &pair = ancestors.at(ancestors.size() - 1);
auto descendantNode = pair.first.get().getChildren().at(pair.second).get();
// Putting the node inside the list.
// Even if this is a node with a `RootNodeKind` trait, we don't treat it as
// root because we measure it from an outside tree perspective.
shadowNodeList.push_back(descendantNode);
for (auto it = ancestors.rbegin(); it != ancestors.rend(); it++) {
auto &shadowNode = it->first.get();
shadowNodeList.push_back(&shadowNode);
if (shadowNode.getTraits().check(ShadowNodeTraits::Trait::RootNodeKind)) {
// If this is a node with a `RootNodeKind` trait, we need to stop right
// there.
break;
}
}
// ------------------------------
// Step 2.
// Computing the initial size of the measured node.
auto descendantLayoutableNode =
traitCast<LayoutableShadowNode const *>(descendantNode);
if (descendantLayoutableNode == nullptr) {
return EmptyLayoutMetrics;
}
// ------------------------------
// TODO: T127619309 remove after validating that T127619309 is fixed
auto optionalCalculateTransformedFrames =
descendantNode->getContextContainer()
? descendantNode->getContextContainer()->find<bool>(
"CalculateTransformedFramesEnabled")
: std::optional<bool>(false);
bool shouldCalculateTransformedFrames =
optionalCalculateTransformedFrames.has_value()
? optionalCalculateTransformedFrames.value()
: false;
auto transformedFrames = shouldCalculateTransformedFrames
? calculateTransformedFrames(shadowNodeList, policy)
: LayoutableSmallVector<Rect>();
auto layoutMetrics = descendantLayoutableNode->getLayoutMetrics();
auto &resultFrame = layoutMetrics.frame;
resultFrame.origin = {0, 0};
// Step 3.
// Iterating on a list of nodes computing compound offset.
auto size = shadowNodeList.size();
for (size_t i = 0; i < size; i++) {
auto currentShadowNode =
traitCast<LayoutableShadowNode const *>(shadowNodeList.at(i));
if (currentShadowNode == nullptr) {
return EmptyLayoutMetrics;
}
// Descendants of display: none don't have relative layout metrics.
if (currentShadowNode->getLayoutMetrics().displayType ==
DisplayType::None) {
return EmptyLayoutMetrics;
}
auto currentFrame = shouldCalculateTransformedFrames
? transformedFrames[i]
: currentShadowNode->getLayoutMetrics().frame;
if (i == size - 1) {
// If it's the last element, its origin is irrelevant.
currentFrame.origin = {0, 0};
}
auto isRootNode = currentShadowNode->getTraits().check(
ShadowNodeTraits::Trait::RootNodeKind);
auto shouldApplyTransformation = (policy.includeTransform && !isRootNode) ||
(policy.includeViewportOffset && isRootNode);
if (shouldApplyTransformation) {
resultFrame.size = resultFrame.size * currentShadowNode->getTransform();
currentFrame = currentFrame * currentShadowNode->getTransform();
}
resultFrame.origin += currentFrame.origin;
if (!shouldCalculateTransformedFrames && i != 0 &&
policy.includeTransform) {
resultFrame.origin += currentShadowNode->getContentOriginOffset();
}
}
// ------------------------------
return layoutMetrics;
}
ShadowNodeTraits LayoutableShadowNode::BaseTraits() {
auto traits = ShadowNodeTraits{};
traits.set(IdentifierTrait());
return traits;
}
ShadowNodeTraits::Trait LayoutableShadowNode::IdentifierTrait() {
return ShadowNodeTraits::Trait::LayoutableKind;
}
LayoutMetrics LayoutableShadowNode::getLayoutMetrics() const {
return layoutMetrics_;
}
void LayoutableShadowNode::setLayoutMetrics(LayoutMetrics layoutMetrics) {
ensureUnsealed();
if (layoutMetrics_ == layoutMetrics) {
return;
}
layoutMetrics_ = layoutMetrics;
}
Transform LayoutableShadowNode::getTransform() const {
return Transform::Identity();
}
Point LayoutableShadowNode::getContentOriginOffset() const {
return {0, 0};
}
LayoutableShadowNode::UnsharedList
LayoutableShadowNode::getLayoutableChildNodes() const {
LayoutableShadowNode::UnsharedList layoutableChildren;
for (const auto &childShadowNode : getChildren()) {
auto layoutableChildShadowNode =
traitCast<LayoutableShadowNode const *>(childShadowNode.get());
if (layoutableChildShadowNode != nullptr) {
layoutableChildren.push_back(
const_cast<LayoutableShadowNode *>(layoutableChildShadowNode));
}
}
return layoutableChildren;
}
Size LayoutableShadowNode::measureContent(
LayoutContext const & /*layoutContext*/,
LayoutConstraints const & /*layoutConstraints*/) const {
return {};
}
Size LayoutableShadowNode::measure(
LayoutContext const &layoutContext,
LayoutConstraints const &layoutConstraints) const {
auto clonedShadowNode = clone({});
auto &layoutableShadowNode =
static_cast<LayoutableShadowNode &>(*clonedShadowNode);
auto localLayoutContext = layoutContext;
localLayoutContext.affectedNodes = nullptr;
layoutableShadowNode.layoutTree(localLayoutContext, layoutConstraints);
return layoutableShadowNode.getLayoutMetrics().frame.size;
}
Float LayoutableShadowNode::firstBaseline(Size /*size*/) const {
return 0;
}
Float LayoutableShadowNode::lastBaseline(Size /*size*/) const {
return 0;
}
ShadowNode::Shared LayoutableShadowNode::findNodeAtPoint(
ShadowNode::Shared const &node,
Point point) {
auto layoutableShadowNode =
traitCast<const LayoutableShadowNode *>(node.get());
if (layoutableShadowNode == nullptr) {
return nullptr;
}
auto frame = layoutableShadowNode->getLayoutMetrics().frame;
auto transformedFrame = frame * layoutableShadowNode->getTransform();
auto isPointInside = transformedFrame.containsPoint(point);
if (!isPointInside) {
return nullptr;
}
auto newPoint = point - transformedFrame.origin -
layoutableShadowNode->getContentOriginOffset();
auto sortedChildren = node->getChildren();
std::stable_sort(
sortedChildren.begin(),
sortedChildren.end(),
[](auto const &lhs, auto const &rhs) -> bool {
return lhs->getOrderIndex() < rhs->getOrderIndex();
});
for (auto it = sortedChildren.rbegin(); it != sortedChildren.rend(); it++) {
auto const &childShadowNode = *it;
auto hitView = findNodeAtPoint(childShadowNode, newPoint);
if (hitView) {
return hitView;
}
}
return isPointInside ? node : nullptr;
}
#if RN_DEBUG_STRING_CONVERTIBLE
SharedDebugStringConvertibleList LayoutableShadowNode::getDebugProps() const {
auto list = SharedDebugStringConvertibleList{};
if (!getIsLayoutClean()) {
list.push_back(std::make_shared<DebugStringConvertibleItem>("dirty"));
}
auto layoutMetrics = getLayoutMetrics();
auto defaultLayoutMetrics = LayoutMetrics();
list.push_back(std::make_shared<DebugStringConvertibleItem>(
"frame", toString(layoutMetrics.frame)));
if (layoutMetrics.borderWidth != defaultLayoutMetrics.borderWidth) {
list.push_back(std::make_shared<DebugStringConvertibleItem>(
"borderWidth", toString(layoutMetrics.borderWidth)));
}
if (layoutMetrics.contentInsets != defaultLayoutMetrics.contentInsets) {
list.push_back(std::make_shared<DebugStringConvertibleItem>(
"contentInsets", toString(layoutMetrics.contentInsets)));
}
if (layoutMetrics.displayType == DisplayType::None) {
list.push_back(std::make_shared<DebugStringConvertibleItem>("hidden"));
}
if (layoutMetrics.layoutDirection == LayoutDirection::RightToLeft) {
list.push_back(std::make_shared<DebugStringConvertibleItem>("rtl"));
}
return list;
}
#endif
} // namespace facebook::react