mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

yukai1 b2d3052de7 ModalHostView's child view can not fill screen (#18615 )

Summary:
Signed-off-by: yukai <yk3372@gmail.com>

In some Android device such as Samsung S8, the ModalHostView's child view can't fill the screen.
before:
![before](https://user-images.githubusercontent.com/1514899/38024961-3e756f8e-32b9-11e8-9555-50a7cf778288.jpeg)
The JS ModalHostView can't fill the bottom, the area is device's navigation bar.

In class ModalHostShadowNode, follow code calculate is error:
`Point modalSize = ModalHostHelper.getModalHostSize(getThemedContext());`
This way not care the device's navigation bar, so the height is smaller than real.
For Samsung S8, real height is 2220 and modalSize.y is 2076.
Pull Request resolved: https://github.com/facebook/react-native/pull/18615

Differential Revision: D14206830

Pulled By: cpojer

fbshipit-source-id: abe35ce1ab253aa1472d2c798543b515218be445

2019-02-25 01:18:42 -08:00

libs

Upgrade Android support library to version 28 in RN

2019-01-22 10:44:53 -08:00

src

ModalHostView's child view can not fill screen (#18615 )

2019-02-25 01:18:42 -08:00

.npmignore

Don't publish /ReactAndroid/build to npm, update version on master

2015-10-12 11:11:40 -07:00

build.gradle

bump targetSdkVersion to 28 (#23431 )