Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
af8ea06bb44e84ce51d4ca4e76f0d66bf34323bd
react-native/React/CoreModules
T
History
Victor Fernandez 7468a6c903 Fix Share dialog not resolving promise when dismissed on iOS (#26842) 
Summary:
On iOS the promised returned by `Share.share(content, options)` isn't resolved if the user dismisses the dialog by either pressing "Cancel" or pressing outside the shared dialog. This PR fixes this issue.

This fixes https://github.com/facebook/react-native/issues/26809.

## Changelog

[iOS] [Fixed] - Fix promised returned by `Share.share(content, options)` not resolving if share dialog dismissed
Pull Request resolved: https://github.com/facebook/react-native/pull/26842

Test Plan:
1. on iOS, open a share dialog with:

```typescript
const onShare = async () => {
  const result = await Share.share({ message: 'example message' });
}
```

2. Dismiss the opened share dialog and the returned promised should resolve.

Differential Revision: D18189755

Pulled By: cpojer

fbshipit-source-id: 1269932e9549026afefdaa8478ff7d33bbaeb86f
2019-10-28 16:24:16 -07:00
..
BUCK
Move RCTImage NativeModules back to RCTImage
2019-10-21 17:15:32 -07:00
CoreModulesPlugins.h
Run depslint on fb_plugin_apple_library rules
2019-10-26 13:47:15 -07:00
CoreModulesPlugins.mm
Move RCTImage NativeModules back to RCTImage
2019-10-21 17:15:32 -07:00
RCTAccessibilityManager.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTAccessibilityManager.mm
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTActionSheetManager.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTActionSheetManager.mm
Fix Share dialog not resolving promise when dismissed on iOS (#26842)
2019-10-28 16:24:16 -07:00
RCTAlertManager.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTAlertManager.mm
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTAppearance.h
iOS Allow disabling color scheme preference
2019-10-23 15:52:45 -07:00
RCTAppearance.mm
iOS: optimize RCTUserInterfaceStyleDidChangeNotification handling
2019-10-23 19:04:36 -07:00
RCTAsyncLocalStorage.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTAsyncLocalStorage.mm
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTClipboard.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTClipboard.mm
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTDeviceInfo.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTDeviceInfo.mm
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTExceptionsManager.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTExceptionsManager.mm
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTI18nManager.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTI18nManager.mm
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTPlatform.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTPlatform.mm
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTSourceCode.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTSourceCode.mm
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTTiming.h
Make RCTTiming TurboModule-compatible
2019-10-16 19:00:26 -07:00
RCTTiming.mm
Make RCTTiming TurboModule-compatible
2019-10-16 19:00:26 -07:00
React-CoreModules.podspec
Move non-license comments out of license header
2019-10-15 20:12:12 -07:00