react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Radek Pietruszewski 733532e5e9 Make JSStringToSTLString 23x faster (#26955 )

Summary:
In my app I have a case where I need to pass a very large string (45MB) between JS and native. This is obviously suboptimal, but… this is where I'm at.

The main bottleneck to doing this turned out to be `jsi`'s `JSStringToSTLString()`, which was extremely slow. In my case, 4.7s to execute. After this change, 204ms.

I don't really know C++, so I'm not sure this code is 100% correct and safe, and I bet it could be done even better by avoiding the extra memory allocation (would shave off another 70ms).

## Changelog

[General] [Changed] - Make JSStringToSTLString 23x faster
Pull Request resolved: https://github.com/facebook/react-native/pull/26955

Reviewed By: shergin

Differential Revision: D19578728

Pulled By: motiz88

fbshipit-source-id: 2fbce83166953ce928f0a6aa36eed710bfe05383

2020-01-28 10:26:25 -08:00

better

Rename isolation root to "default" in fbobjc

2020-01-24 08:26:36 -08:00

callinvoker

Rename isolation root to "default" in fbobjc

2020-01-24 08:26:36 -08:00

config

Rename isolation root to "default" in fbobjc

2020-01-24 08:26:36 -08:00

cxxreact

Use EXPECT instead of ASSERT (repeat 582738b) (#27850 )