react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Samuel Susla af1762cce5 Fix crash in RCTImageComponentView.didReceiveImage

Summary:
Changelog: [Internal]

I went over the ownership model in this call `_state->getData().getImageRequest().getImageInstrumentation().didSetImage();`

1. `getData()` returns reference to an object that is copied to state.
2. `getImageRequest()` returns a reference to an object that is strongly owned by `ImageState`.
3. `getImageInstrumentation()` returns a reference to an object that is strongly owned by `ImageRequest`.

I don't think any of these can cause a crash, however `_state` can be nullptr.

Reviewed By: shergin

Differential Revision: D19599258

fbshipit-source-id: 317f03cd9a53d83f64ccbb9f9abfce10fcc1fae5

2020-01-28 12:04:31 -08:00

Base

Re-land [RN] iOS - deprecate iOS 9 support by removing runtime checks for 10.0+

2020-01-15 09:23:30 -08:00

CoreModules

Enable dev keyboard shortcuts on Mac Catalyst (#27479 )

2020-01-26 19:57:18 -08:00

CxxBridge

Add autorelease pool for each run loop for JS Thread (#27395 )

2019-12-16 23:31:38 -08:00

CxxModule

Replace folly::make_unique with std::make_unique (#26730 )