Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
abff021261bdb9febb40dbd21eb08eab33ec9cfe
react-native/Libraries/Image
T
History
Stanisław Chmiela 663b5a878b Do not override decoders to RCTImageLoader (#29711) 
Summary:
I (actually, [we](https://github.com/expo/expo/issues/9858)) noticed GIFs are no longer animating in Expo client after [enabling TurboModules](https://github.com/expo/expo/pull/9687).

## Changelog

[iOS] [Fixed] - Fix `RCTImageLoader` not using decoders provided.

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

Pull Request resolved: https://github.com/facebook/react-native/pull/29711

Test Plan:
![cat](https://user-images.githubusercontent.com/1151041/90775800-90112c00-e2f9-11ea-95cd-ab95a97068f4.gif)

The cat is moving! Before applying this commit `RCTGIFDecoder` provided in the initalizer is removed from the `_decoders` array in the

```objc
_decoders = [_bridge modulesConformingToProtocol:protocol(RCTImageDataDecoder)];
```

Also, compare

https://github.com/facebook/react-native/blob/8f306cd66a8bc6054ee13701f02329ab5817b69a/Libraries/Image/RCTImageLoader.mm#L243-L250

and

https://github.com/facebook/react-native/blob/8f306cd66a8bc6054ee13701f02329ab5817b69a/Libraries/Image/RCTImageLoader.mm#L177-L184

This PR makes `_decoders` behave the same as `_loaders`.

Reviewed By: PeteTheHeat

Differential Revision: D23908238

Pulled By: fkgozali

fbshipit-source-id: 1d7a6e0d180277f23d8c28916734713bc1833b8b
2020-09-24 10:36:16 -07:00
..
__tests__
Add @react-native/assets package for Asset Registry related code
2020-07-23 05:07:40 -07:00
AssetRegistry.js
Add @react-native/assets package for Asset Registry related code
2020-07-23 05:07:40 -07:00
AssetSourceResolver.js
Add @react-native/assets package for Asset Registry related code
2020-07-23 05:07:40 -07:00
Image.android.js
Rename analyticsTag -> internal_analyticsTag in ImageView component
2020-04-07 17:39:21 -07:00
Image.ios.js
Annotate <Image> components in QPL logging using ImageAnalyticsTagContext
2020-05-23 23:40:24 -07:00
ImageAnalyticsTagContext.js
Fix flow types of ImageContext
2020-04-07 17:39:21 -07:00
ImageBackground.js
Back out "Upgrade Prettier from 1.17 to 2.0.2."
2020-03-24 21:47:35 -07:00
ImagePickerIOS.js
Back out "Upgrade Prettier from 1.17 to 2.0.2."
2020-03-24 21:47:35 -07:00
ImageProps.js
RN: Consistent API for Image Events
2020-06-16 15:01:05 -07:00
ImageResizeMode.js
RN: Replace ImageResizeMode w/ Flow Type
2018-09-28 01:07:30 -07:00
ImageSource.js
RN: Cleanup ImageSource Flow Type
2020-08-27 15:20:09 -07:00
ImageViewNativeComponent.js
Make ColorValue public in StyleSheet.js
2020-04-17 13:03:47 -07:00
ImageViewViewConfig.js
Deploy Flow v0.116 to xplat
2020-01-16 14:05:49 -08:00
NativeImageEditor.js
Open source react-native-modules ESLint rule
2020-09-22 11:32:37 -07:00
NativeImageLoaderAndroid.js
Exact-by-default codemod for react-native-github
2019-11-21 09:42:57 -08:00
NativeImageLoaderIOS.js
Exact-by-default codemod for react-native-github
2019-11-21 09:42:57 -08:00
NativeImagePickerIOS.js
Migrate large amount of modules to flow strict and strict-local
2020-07-22 09:46:16 -07:00
nativeImageSource.js
Updating the URLs to point at new domain name reactnative.dev
2020-02-24 13:09:11 -08:00
NativeImageStore.js
Migrate large amount of modules to flow strict and strict-local
2020-07-22 09:46:16 -07:00
RCTAnimatedImage.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTAnimatedImage.m
fbshipit-source-id: da15f69185e724eaf7d4bc78dbc61fcdcb3074d5
2020-03-13 21:46:45 -07:00
RCTDisplayWeakRefreshable.h
iOS: Fix Animated image crash when CADisplayLink target in RCTWeakProxy is nil
2020-05-12 17:08:43 -07:00
RCTDisplayWeakRefreshable.m
iOS: Fix Animated image crash when CADisplayLink target in RCTWeakProxy is nil
2020-05-12 17:08:43 -07:00
RCTGIFImageDecoder.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTGIFImageDecoder.mm
Make RCTLocalAssetImageLoader and RCTGIFImageDecoder TurboModule-compatible
2019-10-21 17:15:33 -07:00
RCTImageBlurUtils.h
Tidy up license headers [3/n]
2019-10-16 10:06:34 -07:00
RCTImageBlurUtils.m
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTImageCache.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTImageCache.m
Remove unneeded NSNotification center removeObserver
2019-11-04 10:19:30 -08:00
RCTImageDataDecoder.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTImageEditingManager.h
Move RCTImage NativeModules back to RCTImage
2019-10-21 17:15:32 -07:00
RCTImageEditingManager.mm
Part 2: Update ObjC++ codegen classes to use ObjCTurboModule::InitParams
2020-04-16 17:29:55 -07:00
RCTImageLoader.h
3/6 Add IGviewpoint for image visibility callbacks
2020-09-11 15:09:12 -07:00
RCTImageLoader.mm
Do not override decoders to RCTImageLoader (#29711)
2020-09-24 10:36:16 -07:00
RCTImageLoaderInstrumentableProtocol.h
3/6 Add IGviewpoint for image visibility callbacks
2020-09-11 15:09:12 -07:00
RCTImageLoaderProtocol.h
Fix Xcode warnings in React-Core pod (#29622)
2020-09-09 12:48:09 -07:00
RCTImageLoaderWithAttributionProtocol.h
6/6 Log image-rendered for Fabric image logging
2020-09-11 15:09:12 -07:00
RCTImagePlugins.h
Run depslint on fb_plugin_apple_library rules
2019-10-26 13:47:15 -07:00
RCTImagePlugins.mm
Make RCTLocalAssetImageLoader and RCTGIFImageDecoder TurboModule-compatible
2019-10-21 17:15:33 -07:00
RCTImageShadowView.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTImageShadowView.m
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTImageStoreManager.h
Move RCTImage NativeModules back to RCTImage
2019-10-21 17:15:32 -07:00
RCTImageStoreManager.mm
Part 2: Update ObjC++ codegen classes to use ObjCTurboModule::InitParams
2020-04-16 17:29:55 -07:00
RCTImageURLLoader.h
6/6 Log image-rendered for Fabric image logging
2020-09-11 15:09:12 -07:00
RCTImageURLLoaderWithAttribution.h
6/6 Log image-rendered for Fabric image logging
2020-09-11 15:09:12 -07:00
RCTImageURLLoaderWithAttribution.mm
iOS Fabric: added support for image instrumentation [2]
2019-12-16 22:50:45 -08:00
RCTImageUtils.h
Tidy up license headers [3/n]
2019-10-16 10:06:34 -07:00
RCTImageUtils.m
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTImageView.h
Annotate <Image> components in QPL logging using ImageAnalyticsTagContext
2020-05-23 23:40:24 -07:00
RCTImageView.mm
6/6 Log image-rendered for Fabric image logging
2020-09-11 15:09:12 -07:00
RCTImageViewManager.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTImageViewManager.mm
Prefetch images using a lower download priority
2020-06-05 20:55:36 -07:00
RCTLocalAssetImageLoader.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTLocalAssetImageLoader.mm
Remove requestToken being nil check from [RCTNetworkTask validateRequestToken]
2020-07-28 12:00:57 -07:00
RCTResizeMode.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTResizeMode.m
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTUIImageViewAnimated.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTUIImageViewAnimated.m
Hardcode @available(iOS 10) to YES
2020-07-22 11:00:32 -07:00
React-RCTImage.podspec
Upstream RN macOS Hermes integration bits (#29748)
2020-08-27 01:18:33 -07:00
RelativeImageStub.js
Add @react-native/assets package for Asset Registry related code
2020-07-23 05:07:40 -07:00
resolveAssetSource.js
Add @react-native/assets package for Asset Registry related code
2020-07-23 05:07:40 -07:00
TextInlineImageNativeComponent.js
Introduce flow type to differentiate between HostComponent, NativeMethodsMixin, and NativeComponent
2019-09-25 10:12:38 -07:00