mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Rubén Norte abbc6eb022 Modify codegen to throw JS errors instead of crashing when passing non-number arguments where RootTags are expected

Summary:
Changelog: [General][Fixed] Fixed crash when passing non-numeric values where RootTag is expected to methods in native modules using codegen

## Context

Right now, if you have a native module using the codegen with a method like this:

```
someMethod(value: RootTag): void;
```

And you call it like this:

```
NativeModule.someMethod('');
```

The app crashes.

This happens because we cast the JS value to a C++ value using the method that asserts (`toNumber`) instead of the one that throws a JS error (`asNumber`).

## Changes

This fixes the crash by using `asNumber` instead of `toNumber`.

Reviewed By: RSNara

Differential Revision: D54206288

fbshipit-source-id: 9398112667e0f26edaf4f8f3b32e79fa8aafde62

2024-02-27 09:29:53 -08:00

e2e

Modify codegen to throw JS errors instead of crashing when passing non-number arguments where RootTags are expected

2024-02-27 09:29:53 -08:00

scripts

Revert D49370200: Migrate codegen to shared build setup, remove package build pre-step from RNTester

2023-10-23 12:00:54 -07:00

src

Modify codegen to throw JS errors instead of crashing when passing non-number arguments where RootTags are expected

2024-02-27 09:29:53 -08:00

.babelrc

Rewrite ObjC++ module generator