mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Jayme Deffenbaugh
cb719a16cc
Summary: With the upgrade to React Native 0.63, we started running into nullability warnings that were breaking our build. This PR fixes those nullability warnings as well as a few other warnings in React-Core. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For example, see: https://github.com/facebook/react-native/wiki/Changelog --> [iOS] [Fixed] - Fix xcodebuild warnings in React-Core Pull Request resolved: https://github.com/facebook/react-native/pull/29622 Test Plan: - Nullability annotations should only affect compilation, but even though RNTester compiles, I'm not fully convinced that this won't break projects downstream. It would be good to get another opinion on this. - The change in `RCTAllocateRootViewTag` is the only real logic change in this PR. We throw an exception if the root view tag is not in the correct format, so this change seems safe after some basic manual testing in RNTester. Reviewed By: shergin Differential Revision: D23386678 Pulled By: appden fbshipit-source-id: a74875195a4614c3248e8f968aa98602e3ee2de0
104 lines
3.1 KiB
Objective-C
104 lines
3.1 KiB
Objective-C
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import "RCTUIManagerUtils.h"
|
|
|
|
#import <stdatomic.h>
|
|
|
|
#import "RCTAssert.h"
|
|
|
|
char *const RCTUIManagerQueueName = "com.facebook.react.ShadowQueue";
|
|
|
|
static BOOL pseudoUIManagerQueueFlag = NO;
|
|
|
|
dispatch_queue_t RCTGetUIManagerQueue(void)
|
|
{
|
|
static dispatch_queue_t shadowQueue;
|
|
static dispatch_once_t onceToken;
|
|
dispatch_once(&onceToken, ^{
|
|
if ([NSOperation instancesRespondToSelector:@selector(qualityOfService)]) {
|
|
dispatch_queue_attr_t attr =
|
|
dispatch_queue_attr_make_with_qos_class(DISPATCH_QUEUE_SERIAL, QOS_CLASS_USER_INTERACTIVE, 0);
|
|
shadowQueue = dispatch_queue_create(RCTUIManagerQueueName, attr);
|
|
} else {
|
|
shadowQueue = dispatch_queue_create(RCTUIManagerQueueName, DISPATCH_QUEUE_SERIAL);
|
|
dispatch_set_target_queue(shadowQueue, dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_HIGH, 0));
|
|
}
|
|
});
|
|
return shadowQueue;
|
|
}
|
|
|
|
BOOL RCTIsUIManagerQueue()
|
|
{
|
|
static void *queueKey = &queueKey;
|
|
static dispatch_once_t onceToken;
|
|
dispatch_once(&onceToken, ^{
|
|
dispatch_queue_set_specific(RCTGetUIManagerQueue(), queueKey, queueKey, NULL);
|
|
});
|
|
return dispatch_get_specific(queueKey) == queueKey;
|
|
}
|
|
|
|
BOOL RCTIsPseudoUIManagerQueue()
|
|
{
|
|
if (RCTIsMainQueue()) {
|
|
return pseudoUIManagerQueueFlag;
|
|
}
|
|
|
|
return NO;
|
|
}
|
|
|
|
void RCTExecuteOnUIManagerQueue(dispatch_block_t block)
|
|
{
|
|
if (RCTIsUIManagerQueue() || RCTIsPseudoUIManagerQueue()) {
|
|
block();
|
|
} else {
|
|
dispatch_async(RCTGetUIManagerQueue(), ^{
|
|
block();
|
|
});
|
|
}
|
|
}
|
|
|
|
void RCTUnsafeExecuteOnUIManagerQueueSync(dispatch_block_t block)
|
|
{
|
|
if (RCTIsUIManagerQueue() || RCTIsPseudoUIManagerQueue()) {
|
|
block();
|
|
} else {
|
|
if (RCTIsMainQueue()) {
|
|
dispatch_semaphore_t mainQueueBlockingSemaphore = dispatch_semaphore_create(0);
|
|
dispatch_semaphore_t uiManagerQueueBlockingSemaphore = dispatch_semaphore_create(0);
|
|
|
|
// Dispatching block which blocks UI Manager queue.
|
|
dispatch_async(RCTGetUIManagerQueue(), ^{
|
|
// Initiating `block` execution on main queue.
|
|
dispatch_semaphore_signal(mainQueueBlockingSemaphore);
|
|
// Waiting for finishing `block`.
|
|
dispatch_semaphore_wait(uiManagerQueueBlockingSemaphore, DISPATCH_TIME_FOREVER);
|
|
});
|
|
|
|
// Waiting for block on UIManager queue.
|
|
dispatch_semaphore_wait(mainQueueBlockingSemaphore, DISPATCH_TIME_FOREVER);
|
|
pseudoUIManagerQueueFlag = YES;
|
|
// `block` execution while UIManager queue is blocked by semaphore.
|
|
block();
|
|
pseudoUIManagerQueueFlag = NO;
|
|
// Signalling UIManager block.
|
|
dispatch_semaphore_signal(uiManagerQueueBlockingSemaphore);
|
|
} else {
|
|
dispatch_sync(RCTGetUIManagerQueue(), ^{
|
|
block();
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
NSNumber *RCTAllocateRootViewTag()
|
|
{
|
|
// Numbering of these tags goes from 1, 11, 21, 31, ..., 100501, ...
|
|
static _Atomic int64_t rootViewTagCounter = 0;
|
|
return @(atomic_fetch_add_explicit(&rootViewTagCounter, 1, memory_order_relaxed) * 10 + 1);
|
|
}
|