react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Janic Duplessis 7edf9274cf Fix keyboardDismissMode="on-drag" on Android (#31943 )

Summary:
Fixes https://github.com/facebook/react-native/issues/23364

The current logic using `_isTouching` does not work because `_handleTouchCancel` is always called before scroll events begin. This means `_isTouching` is always false. To fix it I moved the logic to `_handleScrollBeginDrag` which is only called once when scroll drag beings. This accomplishes the expected behavior and is better than keeping it in onScroll where it would be called for each scroll event.

## Changelog

[Android] [Fixed] - Fix keyboardDismissMode="on-drag" on Android

Pull Request resolved: https://github.com/facebook/react-native/pull/31943

Test Plan: Tested in an app that on-drag does not work before and works after this patch.

Reviewed By: sshic

Differential Revision: D30674276

Pulled By: yungsters

fbshipit-source-id: aa0bd605809fa01518f70fbf323c06e32c76ed1d

2021-09-02 13:20:04 -07:00

__tests__

Fix inline requires for ESM in react-native-github

2021-06-04 13:05:11 -07:00

AndroidHorizontalScrollContentViewNativeComponent.js

Fix RTL scrolling

2021-02-25 10:09:32 -08:00

AndroidHorizontalScrollViewNativeComponent.js

Convert require to import in Libraries/Components

2021-04-26 12:50:59 -07:00

processDecelerationRate.js

Remove "use strict" directive from ES Modules