react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Eli White a669de1dd2 Parse string unions as StringLiteralUnionTypeAnnotation (#46845 )

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/46845

Previously, the parser was throwing away the values of a string union when storing it in the schema. It would only store the union as

```
{
  type: 'UnionTypeAnnotation',
  memberType: 'StringTypeAnnotation'
}
```

We now track the string literals through the parser and store them in the schema:

```
{
  type: 'StringLiteralUnionTypeAnnotation',
  types: [
    {
      type: 'StringLiteralTypeAnnotation'
      value: 'light'
    },
    {
      type: 'StringLiteralTypeAnnotation'
      value: 'dark'
    },
  ],
}
```

We aren't changing the generators, those still just output "string". They could eventually be made smarter.

The value of this is that the compat checker can now error when the union changes.

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D63917685

fbshipit-source-id: 34a10e1f1910d2935837a3659f66049fd4473134

2024-10-07 16:56:04 -07:00

__tests__

Parse string unions as StringLiteralUnionTypeAnnotation (#46845 )

2024-10-07 16:56:04 -07:00

consistency

Enable lint/sort-imports everywhere (#41334 )

2023-11-06 12:59:38 -08:00

flow

Parse string unions as StringLiteralUnionTypeAnnotation (#46845 )

2024-10-07 16:56:04 -07:00

schema

Enforce compatibility with exactOptionalPropertyTypes (#36345 )