Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
a65cd683aee40fbb0433f43e15b8366dc1fa02a4
react-native/ReactCommon/react/renderer/core
T
History
Samuel SuslaandFacebook GitHub Bot e6931caca4 Don't retain State in StateWrapperImpl 
Summary:
Changelog: [internal]

StateWrapperImpl shouldn't retain State strongly because cleanup of `StateWrapperImpl` is triggered from Java and isn't guaranteed to take happen before runtime is destroyed.

This should resolve crash where `StateWrapperImpl`'s destruction causes a `~Pointer` to be called after runtime is destroyed.

Chain of ownership that will be broken by storing State weakly inside `StateWrapperImpl`.
`StateWrapperImpl -> ParagraphState -> TextLayourManager's cache -> AttributedString -> ShadowView -> EventEmitter -> EventTarget -> Pointer`

{F451105831}

Reviewed By: JoshuaGross

Differential Revision: D26815275

fbshipit-source-id: 0703c6dccc62c1d152923b786a83273fa8a03694
2021-03-04 13:14:39 -08:00
..
tests
ReactCommon/renderer/core: Migrate uses of NDEBUG to REACT_NATIVE_DEBUG + react_native_assert
2021-02-26 23:29:59 -08:00
Android.mk
Update Android.mk to ensure the rn-tester compiles in debug mode
2021-02-24 12:29:00 -08:00
BatchedEventQueue.cpp
Make EventQueue a virtual class
2021-01-07 13:42:24 -08:00
BatchedEventQueue.h
Remove v1 event coalescing
2021-01-04 04:12:30 -08:00
BUCK
ReactCommon/renderer/core: Migrate uses of NDEBUG to REACT_NATIVE_DEBUG + react_native_assert
2021-02-26 23:29:59 -08:00
ComponentDescriptor.cpp
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
ComponentDescriptor.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
ConcreteComponentDescriptor.h
Convert most Fabric Cxx code to use react_native_assert instead of assert
2021-02-19 20:52:52 -08:00
ConcreteShadowNode.h
Convert most Fabric Cxx code to use react_native_assert instead of assert
2021-02-19 20:52:52 -08:00
ConcreteState.h
Convert most Fabric Cxx code to use react_native_assert instead of assert
2021-02-19 20:52:52 -08:00
Constants.cpp
Introducing: Props forwarding whe cloning shadow node
2021-01-28 11:21:21 -08:00
Constants.h
Introducing: Props forwarding whe cloning shadow node
2021-01-28 11:21:21 -08:00
conversions.h
Fix changes of View visibilities
2021-01-10 19:46:40 -08:00
DynamicPropsUtilities.cpp
Correctly handle null values in dynamic props in prop forwarding
2021-02-22 05:53:24 -08:00
DynamicPropsUtilities.h
Correctly handle null values in dynamic props in prop forwarding
2021-02-22 05:53:24 -08:00
EventBeat.cpp
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
EventBeat.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
EventDispatcher.cpp
Remove v1 event coalescing
2021-01-04 04:12:30 -08:00
EventDispatcher.h
Remove v1 event coalescing
2021-01-04 04:12:30 -08:00
EventEmitter.cpp
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
EventEmitter.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
EventHandler.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
EventPipe.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
EventPriority.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
EventQueue.cpp
Make EventQueue a virtual class
2021-01-07 13:42:24 -08:00
EventQueue.h
Make EventQueue a virtual class
2021-01-07 13:42:24 -08:00
EventTarget.cpp
Convert most Fabric Cxx code to use react_native_assert instead of assert
2021-02-19 20:52:52 -08:00
EventTarget.h
Fabric: Marking all JS function lambdas noexcept in UIManagerBinding
2020-09-18 17:07:29 -07:00
LayoutableShadowNode.cpp
Remove unused methods from LayoutableShadowNode
2020-12-23 04:45:54 -08:00
LayoutableShadowNode.h
Convert most Fabric Cxx code to use react_native_assert instead of assert
2021-02-19 20:52:52 -08:00
LayoutConstraints.cpp
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
LayoutConstraints.h
Apply clang-format update fixes
2021-01-09 22:11:00 -08:00
LayoutContext.h
Fabric: operator== for LayoutContext
2020-10-15 10:47:11 -07:00
LayoutMetrics.h
Apply clang-format update fixes
2021-01-09 22:11:00 -08:00
LayoutPrimitives.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
Props.cpp
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
Props.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
propsConversions.h
move fabric to ReactCommon/react/renderer
2020-07-31 13:34:29 -07:00
RawEvent.cpp
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
RawEvent.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
RawProps.cpp
Convert most Fabric Cxx code to use react_native_assert instead of assert
2021-02-19 20:52:52 -08:00
RawProps.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
RawPropsKey.cpp
Convert most Fabric Cxx code to use react_native_assert instead of assert
2021-02-19 20:52:52 -08:00
RawPropsKey.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
RawPropsKeyMap.cpp
Convert most Fabric Cxx code to use react_native_assert instead of assert
2021-02-19 20:52:52 -08:00
RawPropsKeyMap.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
RawPropsParser.cpp
RN_DEBUG -> REACT_NATIVE_DEBUG
2021-02-18 14:31:57 -08:00
RawPropsParser.h
Apply clang-format update fixes
2021-01-09 22:11:00 -08:00
RawPropsPrimitives.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
RawValue.cpp
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
RawValue.h
Convert most Fabric Cxx code to use react_native_assert instead of assert
2021-02-19 20:52:52 -08:00
ReactPrimitives.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
Sealable.cpp
ReactCommon/renderer/core: Migrate uses of NDEBUG to REACT_NATIVE_DEBUG + react_native_assert
2021-02-26 23:29:59 -08:00
Sealable.h
ReactCommon/renderer/core: Migrate uses of NDEBUG to REACT_NATIVE_DEBUG + react_native_assert
2021-02-26 23:29:59 -08:00
ShadowNode.cpp
Correctly handle null values in dynamic props in prop forwarding
2021-02-22 05:53:24 -08:00
ShadowNode.h
Pass weak pointers to background executor lambda
2021-02-22 17:02:19 -08:00
ShadowNodeFamily.cpp
Convert most Fabric Cxx code to use react_native_assert instead of assert
2021-02-19 20:52:52 -08:00
ShadowNodeFamily.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
ShadowNodeFamilyFragment.cpp
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
ShadowNodeFamilyFragment.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
ShadowNodeFragment.cpp
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
ShadowNodeFragment.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
ShadowNodeTraits.cpp
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
ShadowNodeTraits.h
Fabric: Implementation for ShadowNodeTraits::Trait::MeasurableYogaNode
2021-01-16 15:53:55 -08:00
State.cpp
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
State.h
Don't retain State in StateWrapperImpl
2021-03-04 13:14:39 -08:00
StateData.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
StatePipe.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
StateUpdate.cpp
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
StateUpdate.h
Fabric: Shipping updateStateWithAutorepeat as the only way to update a state
2020-12-23 21:49:44 -08:00
UnbatchedEventQueue.cpp
Make EventQueue a virtual class
2021-01-07 13:42:24 -08:00
UnbatchedEventQueue.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00
ValueFactory.h
Remove inner folders of react/renderer/core
2020-08-01 13:31:03 -07:00