mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Luna Wei
b095432e6d
Summary: ## Changelog: [Internal][Changed] - Prevent symbolicating stacktrace and no logbox when running in express route Context: ExpressRoute doesn't support some things (like promises) due to the limited initialization we do. Right now the app will crash when trying to evaluate those entrypoints in express route if they depend on such initialization. Ideally a redbox would warn the developer that express route would break if they modify their express-route compatible entrypoint. Displaying a redbox seems to require a bit of refactoring as it can't easily be triggered from native/express-route -- something more to investigate. Occasionally one does appear (when trying the attached test plan) but it is inconsistent and seems dependent on timing of bridge, express route initialization. The plan: * Since we are going to roll out an opt-in for each surface (note there are two flags, `fetchWithExpressRouteIfAvailable` and `useExpressRouteIfInitialized` - the former being for using `getPreloadProps` to parallel fetch and the latter as a flag to get route information) we have more control of the roll out of express route. Things still to improve: * It's obviously not great that we don't get better errors -- something to address if that is really the next blocker to rolling out ExpressRoute Reviewed By: sahrens, ejanzer Differential Revision: D22026444 fbshipit-source-id: 7698109f5921f82a2d0bc9a8346e12b67defca27