mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Daniel Abramowitz a3e25b23c6 Improve exception thrown when classes can't compile to be more clear (#33897 )

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/33897

Now the exception will display the class which caused the exception as well as helpful information as to why.

We've seen this happen a bunch due and have been very confused by the error message. It turns out that this processor runs before the classes listed are compiled. This means that if there's a compile error (or a missing import) the user will only see that this processor crashed, and not the compile error.

The additional information in the error is:

`java.lang.RuntimeException: Could not load classes set in ReactModuleList.nativeModules. Check that they exist and are imported correctly on class: com.meta.x.y.ReactPackage`

In this case,  `com.meta.x.y.ReactPackage` is the class which needs to be fixed. Before, the error message made no mention of this class or the annotation.

Changelog: [Internal] This will change the way the annotation processor crashes. It will throw a RuntimeException instead of a ClassCastException.

Reviewed By: javache

Differential Revision: D36606279

fbshipit-source-id: aedf9682286fba49e23716b7eda16b2dd3b13422

2022-05-26 08:13:22 -07:00

hermes-engine

Disable Javadoc publishing as it's currently failing on CI

2022-05-18 11:48:16 -07:00

libs

…

src

Improve exception thrown when classes can't compile to be more clear (#33897 )

2022-05-26 08:13:22 -07:00

.npmignore

Do not publish Android tests inside the NPM package

2022-05-23 12:28:33 -07:00