mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Nick Gerleman
9fe20d4ea3
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/51465 Prior to D63303709 AttributedString could not represent formatting on an empty string, and so some text content was forcefully added to empty strings during measurement. This is problematic in combination with Facsimile, where we directly render the layout we used during measurement, since empty text now has a random "I" in it. Android's TextLayoutManager already knows how to interpret `baseTextAttributes`, and the placeholder is not needed. Other platforms should be updated to do the same, but that may be non-trivial to validate everywhere. This diff removes logic from ShadowNodes to always inset a placeholder, and instead shims it in platform TextLayoutManagers which have not yet been updated to use `BaseTextAttributes`. That way, we don't force placeholders during measurement, and different platforms can incrementally unjank their code. Changelog: [Internal] Reviewed By: rshest Differential Revision: D74770916 fbshipit-source-id: 7cf19db1a9a5cf68137bbff81b14ce5288235b2b