Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
9c27ccd7d032c778b2d5718507aca41c9063f2ca
react-native/ReactAndroid/src/main/java/com/facebook/react/bridge
T
History
Ramanpreet NaraandFacebook Github Bot d43059d0b8 Correct ReactModuleSpecProcessor TurboModule detection logic 
Summary:
## Problem
For efficiency reasons, we'd only check whether the current class or its superclass implemented the `TurboModule` interface. However, it's possible for NativeModules to exist that use inheritance, and have their base class extend a code-generated spec. In this case, the superclass of the superclass of the NativeModule will implement `TurboModule`.

## Solution
To fix this problem, I'm relying on the `Types.isAssignable` API and checking whether the NativeModule can be assigned to the `TurboModule` interface. This is a more reliable way of knowing whether a NativeModule is a TurboModule or not.

**Note:** Had to adjust the buck dependencies of FrescoModule to make the `mTypes.isAssignable` check work.

Changelog:
[Android][Fixed] - Correct TurboModule detection logic in ReactModuleSpecProcessor

Reviewed By: fkgozali

Differential Revision: D19183671

fbshipit-source-id: ad21881453fe7027d9432048108f6ba344fd7e63
2019-12-20 08:49:05 -08:00
..
queue
Remove NativeRunnableDeprecated (#27529)
2019-12-17 13:23:59 -08:00
ActivityEventListener.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
Arguments.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
AssertionException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
BaseActivityEventListener.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
BaseJavaModule.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
bridge.pro
RN: Missing Copyright Headers
2018-10-31 01:37:26 -07:00
BUCK
Correct ReactModuleSpecProcessor TurboModule detection logic
2019-12-20 08:49:05 -08:00
Callback.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
CallbackImpl.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
CatalystInstance.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
CatalystInstanceImpl.java
Make TurboModuleRegistry in CatalystInstanceImpl.java volatile
2019-11-15 17:31:31 -08:00
ContextBaseJavaModule.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
CxxCallbackImpl.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
CxxModuleWrapper.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
CxxModuleWrapperBase.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
DefaultNativeModuleCallExceptionHandler.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
Dynamic.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
DynamicFromArray.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
DynamicFromMap.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
DynamicFromObject.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
FallbackJSBundleLoader.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
GuardedAsyncTask.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
GuardedResultAsyncTask.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
GuardedRunnable.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
Inspector.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
InvalidIteratorException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaJSExecutor.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaMethodWrapper.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaModuleWrapper.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaOnlyArray.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaOnlyMap.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaScriptContextHolder.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
JavaScriptExecutor.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaScriptExecutorFactory.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaScriptModule.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaScriptModuleRegistry.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSApplicationCausedNativeException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSApplicationIllegalArgumentException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSBundleLoader.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSBundleLoaderDelegate.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSCJavaScriptExecutor.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSCJavaScriptExecutorFactory.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSIModule.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSIModuleHolder.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSIModulePackage.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSIModuleProvider.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSIModuleRegistry.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSIModuleSpec.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSIModuleType.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSInstance.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JsonWriterHelper.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
LifecycleEventListener.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
MemoryPressure.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
MemoryPressureListener.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
ModuleHolder.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
ModuleSpec.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeArgumentsParseException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeArray.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeArrayInterface.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeMap.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeModule.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeModuleCallExceptionHandler.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeModuleRegistry.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NoSuchKeyException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NotThreadSafeBridgeIdleDebugListener.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ObjectAlreadyConsumedException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
OnBatchCompleteListener.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
PerformanceCounter.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
Promise.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
PromiseImpl.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ProxyJavaScriptExecutor.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReactApplicationContext.java
Clean up unused functions on ReactContext
2019-12-03 11:33:00 -08:00
ReactBridge.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReactCallback.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReactContext.java
Refactor ReactContext to use IllegalStateException instead of RuntimeException
2019-12-11 18:39:51 -08:00
ReactContextBaseJavaModule.java
Check bridgeless mode in getReactApplicationContextIfActiveOrWarn
2019-12-17 18:38:57 -08:00
ReactMarker.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
ReactMarkerConstants.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
ReactMethod.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReactModuleWithSpec.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
reactnative.pro
RN: Missing Copyright Headers
2018-10-31 01:37:26 -07:00
ReactNoCrashSoftException.java
In modules or classes that call ReactApplicationContext.getJSModule, ensure that there's still a CatalystInstance alive
2019-10-24 17:29:08 -07:00
ReactSoftException.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
ReadableArray.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReadableMap.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReadableMapKeySetIterator.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReadableNativeArray.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReadableNativeMap.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReadableType.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
SoftAssertions.java
UiThreadUtil.assertX should only throw in DEBUG mode
2019-11-05 15:36:29 -08:00
Systrace.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
UIManager.java
Expose getEventDispatcher() method into UIManager interface
2019-12-10 20:33:55 -08:00
UiThreadUtil.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
UnexpectedNativeTypeException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
WindowFocusChangeListener.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
WritableArray.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
WritableMap.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
WritableNativeArray.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
WritableNativeMap.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00