react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Janic Duplessis 9b2374b542 Release underlying resources when JS instance is GC'ed on Android try 2 (#26155 )

Summary:
Reland https://github.com/facebook/react-native/pull/24767

The commit had to be reverted because it caused a crash when using remote debugging in chrome. This is normal since jsi is not available in that environment. The crash was caused by `jsContext.get()` being 0, then being dereferenced later in c++. We can simply skip initializing the blob collector in this case.

This also includes the fix from https://github.com/facebook/react-native/issues/25720 to fix a crash when using hermes.

## Changelog

[Android] [Fixed] - Release underlying resources when JS instance is GC'ed on Android
Pull Request resolved: https://github.com/facebook/react-native/pull/26155

Test Plan:
Test using RN tester with jsc and hermes
Test remote debugging

Reviewed By: mdvacca, fred2028

Differential Revision: D17072644

Pulled By: makovkastar

fbshipit-source-id: 079d1d43501e854297fbbe586ba229920c892584

2019-09-18 04:52:43 -07:00

jni

Release underlying resources when JS instance is GC'ed on Android try 2 (#26155 )

2019-09-18 04:52:43 -07:00

BlobCollector.java

Release underlying resources when JS instance is GC'ed on Android try 2 (#26155 )

2019-09-18 04:52:43 -07:00

BlobModule.java

Release underlying resources when JS instance is GC'ed on Android try 2 (#26155 )

2019-09-18 04:52:43 -07:00

BlobProvider.java

Use try-with-resource to prevent output stream to be leaked in BlobProvider