mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Ramanpreet Nara
9ae95582e7
Summary: ## Description You're not supposed to hold on to JSI objects (ex: `jsi::Function`) past the point where their `jsi::Runtime` is deleted. Otherwise, we get a dangling pointer crash, like this: T60262810! Historically, this cleanup problem has always been really tricky to get right. With this diff, I hope to fix that problem once and for all by deleting all `jsi::Function`s when we delete the global `__turboModuleProxy` function. ## Current Setup - The TurboModules infra uses weak references to `CallbackWrapper`s to hold on to the `jsi::Function`s passed from JS to ObjC. - The LongLivedObjectCollection holds on to strong references to `CallbackWrapper`s. This ensures that the `jsi::Function`s aren't deleted prematurely. This also means that we can use `LongLivedObjectCollection` to delete all `CallbackWrappers`. - `TurboModuleBinding` is the abstraction we use to install the global `__turboModuleProxy` function. It is owned by `TurboModuleManager`, and `TurboModuleManager` uses it to clear all references to `jsi::Function`s, when we delete all NativeModules. ## Solution 1. Transfer ownership of `TurboModuleBinding` from `TurboModuleManager` to the `__turboModuleProxy` function. 2. Clear the `LongLivedObjectCollection` when `TurboModuleBinding` is deleted. Changelog: [iOS][Fixed] - Clear all held jsi::Functions when jsi::Runtime is deleted Reviewed By: JoshuaGross Differential Revision: D19565499 fbshipit-source-id: e3510ea04e72f6bda363a8fc3ee2be60303b70a6
82 lines
2.2 KiB
C++
82 lines
2.2 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "TurboModuleBinding.h"
|
|
|
|
#include <string>
|
|
|
|
#include <ReactCommon/LongLivedObject.h>
|
|
#include <cxxreact/SystraceSection.h>
|
|
|
|
using namespace facebook;
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
/**
|
|
* Public API to install the TurboModule system.
|
|
*/
|
|
TurboModuleBinding::TurboModuleBinding(
|
|
const TurboModuleProviderFunctionType &&moduleProvider)
|
|
: moduleProvider_(std::move(moduleProvider)) {}
|
|
|
|
void TurboModuleBinding::install(
|
|
jsi::Runtime &runtime,
|
|
const TurboModuleProviderFunctionType &&moduleProvider) {
|
|
runtime.global().setProperty(
|
|
runtime,
|
|
"__turboModuleProxy",
|
|
jsi::Function::createFromHostFunction(
|
|
runtime,
|
|
jsi::PropNameID::forAscii(runtime, "__turboModuleProxy"),
|
|
1,
|
|
[binding =
|
|
std::make_shared<TurboModuleBinding>(std::move(moduleProvider))](
|
|
jsi::Runtime &rt,
|
|
const jsi::Value &thisVal,
|
|
const jsi::Value *args,
|
|
size_t count) {
|
|
return binding->jsProxy(rt, thisVal, args, count);
|
|
}));
|
|
}
|
|
|
|
TurboModuleBinding::~TurboModuleBinding() {
|
|
LongLivedObjectCollection::get().clear();
|
|
}
|
|
|
|
std::shared_ptr<TurboModule> TurboModuleBinding::getModule(
|
|
const std::string &name) {
|
|
std::shared_ptr<TurboModule> module = nullptr;
|
|
{
|
|
SystraceSection s("TurboModuleBinding::getModule", "module", name);
|
|
module = moduleProvider_(name);
|
|
}
|
|
return module;
|
|
}
|
|
|
|
jsi::Value TurboModuleBinding::jsProxy(
|
|
jsi::Runtime &runtime,
|
|
const jsi::Value &thisVal,
|
|
const jsi::Value *args,
|
|
size_t count) {
|
|
if (count != 1) {
|
|
throw std::invalid_argument(
|
|
"TurboModuleBinding::jsProxy arg count must be 1");
|
|
}
|
|
std::string moduleName = args[0].getString(runtime).utf8(runtime);
|
|
std::shared_ptr<TurboModule> module = getModule(moduleName);
|
|
|
|
if (module == nullptr) {
|
|
return jsi::Value::null();
|
|
}
|
|
|
|
return jsi::Object::createFromHostObject(runtime, std::move(module));
|
|
}
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|