mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Lukas Weber
0d4b0e9417
Summary: When `[RCTReconnectingWebSocket stop]` is called and `[RCTReconnectingWebSocket reconnect]` is scheduled afterwards (i.e. connection didn't happen before `[RCTReconnectingWebSocket stop]` being invoked), it will keep reconnecting forever. Also fixes retain loop in block within `[RCTReconnectingWebSocket reconnect]`. When RCTReconnectingWebSocket is stopped and reference to it set to nil, block in reconnect will still keep self alive and reconnecting forever. I found this edge case when I tried to stop RCTPackagerConnection after some time, so it doesn't spam with `[] nw_socket_handle_socket_event [C34585.1:1] Socket SO_ERROR [61: Connection refused]` when we don' have Metro running (we have brownfield app, so iOS devs don't need Metro running most of the time). ## Changelog [iOS] [Fixed] - RCTReconnectingWebSocket is reconnecting infinitely when stopped before getting connected Pull Request resolved: https://github.com/facebook/react-native/pull/26864 Test Plan: - Put breakpoint into `[RCTReconnectingWebSocket reconnect]` - Start sample RN app **without having Metro running** - Into AppDelegate add something like ```objc dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(5 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{ [RCTPackagerConnection.sharedPackagerConnection stop] }); ``` - After the previous block is dispatched reconnect should not be invoked anymore Reviewed By: motiz88 Differential Revision: D19767742 Pulled By: rickhanlonii fbshipit-source-id: dabb2369b06217b961e9d2611257c106d350f70c
107 lines
2.2 KiB
Objective-C
107 lines
2.2 KiB
Objective-C
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import <React/RCTReconnectingWebSocket.h>
|
|
|
|
#import <React/RCTConvert.h>
|
|
#import <React/RCTDefines.h>
|
|
|
|
#import <React/RCTSRWebSocket.h>
|
|
|
|
#if RCT_DEV // Only supported in dev mode
|
|
|
|
@interface RCTReconnectingWebSocket () <RCTSRWebSocketDelegate>
|
|
@end
|
|
|
|
@implementation RCTReconnectingWebSocket {
|
|
NSURL *_url;
|
|
RCTSRWebSocket *_socket;
|
|
BOOL _stopped;
|
|
}
|
|
|
|
- (instancetype)initWithURL:(NSURL *)url queue:(dispatch_queue_t)queue
|
|
{
|
|
if (self = [super init]) {
|
|
_url = url;
|
|
_delegateDispatchQueue = queue;
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (instancetype)initWithURL:(NSURL *)url
|
|
{
|
|
return [self initWithURL:url queue:dispatch_get_main_queue()];
|
|
}
|
|
|
|
- (void)send:(id)data
|
|
{
|
|
[_socket send:data];
|
|
}
|
|
|
|
- (void)start
|
|
{
|
|
[self stop];
|
|
_stopped = NO;
|
|
_socket = [[RCTSRWebSocket alloc] initWithURL:_url];
|
|
_socket.delegate = self;
|
|
[_socket setDelegateDispatchQueue:_delegateDispatchQueue];
|
|
[_socket open];
|
|
}
|
|
|
|
- (void)stop
|
|
{
|
|
_stopped = YES;
|
|
_socket.delegate = nil;
|
|
[_socket closeWithCode:1000 reason:@"Invalidated"];
|
|
_socket = nil;
|
|
}
|
|
|
|
- (void)webSocket:(RCTSRWebSocket *)webSocket didReceiveMessage:(id)message
|
|
{
|
|
[_delegate reconnectingWebSocket:self didReceiveMessage:message];
|
|
}
|
|
|
|
- (void)reconnect
|
|
{
|
|
if (_stopped) {
|
|
return;
|
|
}
|
|
|
|
__weak RCTSRWebSocket *socket = _socket;
|
|
__weak __typeof(self) weakSelf = self;
|
|
|
|
dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(2 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
|
|
[weakSelf start];
|
|
if (!socket) {
|
|
[weakSelf reconnect];
|
|
}
|
|
});
|
|
}
|
|
|
|
- (void)webSocketDidOpen:(RCTSRWebSocket *)webSocket
|
|
{
|
|
[_delegate reconnectingWebSocketDidOpen:self];
|
|
}
|
|
|
|
- (void)webSocket:(RCTSRWebSocket *)webSocket didFailWithError:(NSError *)error
|
|
{
|
|
[_delegate reconnectingWebSocketDidClose:self];
|
|
if ([error code] != ECONNREFUSED) {
|
|
[self reconnect];
|
|
}
|
|
}
|
|
|
|
- (void)webSocket:(RCTSRWebSocket *)webSocket didCloseWithCode:(NSInteger)code reason:(NSString *)reason wasClean:(BOOL)wasClean
|
|
{
|
|
[_delegate reconnectingWebSocketDidClose:self];
|
|
[self reconnect];
|
|
}
|
|
|
|
@end
|
|
|
|
#endif
|