mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
David Vacca
5d414665ea
Summary: This diff fixes the release of ImageRequest object. The responseFutureSplitter_ can be destroyed by the time ~ImageRequest is executed. See P60163877 for original crash (this crash was reproducible when reloading or closing a Fabric screen that contains several images. Reviewed By: shergin Differential Revision: D10282207 fbshipit-source-id: 4f0894959e54f6d15b98e216df102e764866e387
51 lines
1.3 KiB
C++
51 lines
1.3 KiB
C++
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "ImageRequest.h"
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
class ImageRequest::ImageNoLongerNeededException : public std::logic_error {
|
|
public:
|
|
ImageNoLongerNeededException()
|
|
: std::logic_error("Image no longer needed.") {}
|
|
};
|
|
|
|
ImageRequest::ImageRequest(
|
|
const ImageSource &imageSource,
|
|
folly::Future<ImageResponse> &&responseFuture)
|
|
: imageSource_(imageSource),
|
|
responseFutureSplitter_(folly::splitFuture(std::move(responseFuture))) {}
|
|
|
|
ImageRequest::ImageRequest(ImageRequest &&other) noexcept
|
|
: imageSource_(std::move(other.imageSource_)),
|
|
responseFutureSplitter_(std::move(other.responseFutureSplitter_)) {
|
|
other.moved_ = true;
|
|
};
|
|
|
|
ImageRequest::~ImageRequest() {
|
|
if (!moved_) {
|
|
auto future = responseFutureSplitter_.getFuture();
|
|
if (!future.isReady()) {
|
|
future.raise(ImageNoLongerNeededException());
|
|
}
|
|
}
|
|
}
|
|
|
|
folly::Future<ImageResponse> ImageRequest::getResponseFuture() const {
|
|
if (moved_) {
|
|
abort();
|
|
}
|
|
|
|
std::lock_guard<std::mutex> lock(mutex_);
|
|
return responseFutureSplitter_.getFuture();
|
|
}
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|