mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Paige Sun
37e5fa3a6c
Summary: Changelog: [iOS][Internal] Refactor: Migrate Logbox surface initialization to Fabric when available, in Bridge and Bridgeless modes # Why This diff main purpose is to add `RCTErrorNewArchitectureValidation(RCTNotAllowedInAppWideFabric)` in `RCTSurface`, to ensure Paper surfaces are never created in FBiOS. # The Situation Before this diff, in Bridged Fabric, `[RCTLogbox show]` initializes a Paper `RCTSurface`, [using `[RCTLogBoxView initWithWindow]`](https://github.com/facebook/react-native/blob/main/React/CoreModules/RCTLogBoxView.mm#L46)) In this diff, in Bridged and Bridgeless Fabric, `[RCTLogbox show]` initializes a Fabric `RCTFabricSurface`. Before this diff, in Bridgeless Fabric, RCTLogBox posts a "CreateLogBoxSurface" notification to RCTInstance. In this diff, the notification hack is replaced by the same `RCTFabricSurface` initialization above. Behavior is the same. Reviewed By: RSNara Differential Revision: D35177311 fbshipit-source-id: 6de418af8a01f914c9a806bb8d74915015f9087a
93 lines
2.5 KiB
Plaintext
93 lines
2.5 KiB
Plaintext
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import "RCTLogBoxView.h"
|
|
|
|
#import <React/RCTLog.h>
|
|
#import <React/RCTSurface.h>
|
|
#import <React/RCTSurfaceHostingView.h>
|
|
|
|
@implementation RCTLogBoxView {
|
|
RCTSurface *_surface;
|
|
}
|
|
|
|
- (instancetype)initWithFrame:(CGRect)frame
|
|
{
|
|
if ((self = [super initWithFrame:frame])) {
|
|
self.windowLevel = UIWindowLevelStatusBar - 1;
|
|
self.backgroundColor = [UIColor clearColor];
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (void)createRootViewController:(UIView *)view
|
|
{
|
|
UIViewController *_rootViewController = [UIViewController new];
|
|
_rootViewController.view = view;
|
|
_rootViewController.view.backgroundColor = [UIColor clearColor];
|
|
_rootViewController.modalPresentationStyle = UIModalPresentationFullScreen;
|
|
self.rootViewController = _rootViewController;
|
|
}
|
|
|
|
- (instancetype)initWithFrame:(CGRect)frame surfacePresenter:(id<RCTSurfacePresenterStub>)surfacePresenter
|
|
{
|
|
if (self = [super initWithFrame:frame]) {
|
|
id<RCTSurfaceProtocol> surface = [surfacePresenter createFabricSurfaceForModuleName:@"LogBox"
|
|
initialProperties:@{}];
|
|
[surface start];
|
|
RCTSurfaceHostingView *rootView = [[RCTSurfaceHostingView alloc]
|
|
initWithSurface:surface
|
|
sizeMeasureMode:RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact];
|
|
|
|
[self createRootViewController:rootView];
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (instancetype)initWithWindow:(UIWindow *)window bridge:(RCTBridge *)bridge
|
|
{
|
|
RCTErrorNewArchitectureValidation(RCTNotAllowedInAppWideFabric, @"RCTLogBoxView", nil);
|
|
|
|
if (@available(iOS 13.0, *)) {
|
|
self = [super initWithWindowScene:window.windowScene];
|
|
} else {
|
|
self = [super initWithFrame:window.frame];
|
|
}
|
|
|
|
self.windowLevel = UIWindowLevelStatusBar - 1;
|
|
self.backgroundColor = [UIColor clearColor];
|
|
|
|
_surface = [[RCTSurface alloc] initWithBridge:bridge moduleName:@"LogBox" initialProperties:@{}];
|
|
[_surface start];
|
|
|
|
if (![_surface synchronouslyWaitForStage:RCTSurfaceStageSurfaceDidInitialMounting timeout:1]) {
|
|
RCTLogInfo(@"Failed to mount LogBox within 1s");
|
|
}
|
|
[self createRootViewController:(UIView *)_surface.view];
|
|
|
|
return self;
|
|
}
|
|
|
|
- (void)layoutSubviews
|
|
{
|
|
[super layoutSubviews];
|
|
[_surface setSize:self.frame.size];
|
|
}
|
|
|
|
- (void)dealloc
|
|
{
|
|
[RCTSharedApplication().delegate.window makeKeyWindow];
|
|
}
|
|
|
|
- (void)show
|
|
{
|
|
[self becomeFirstResponder];
|
|
[self makeKeyAndVisible];
|
|
}
|
|
|
|
@end
|