Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
97d439e0baee3cba2b2e0841bbb8f8db88965fb1
react-native/Libraries/Text/TextInput
T
History
zhongwuzw 9b61896f40 Don't apply empty attributed string for TextInput (#25143) 
Summary:
Issue reported by Titozzz , `TextInput` would shrink when we have attributes like `lineHeight`.
Demonstration can see GIF like below:
https://giphy.com/gifs/KGNs1qIMHF3DIk1EPK

I think the reason is we apply an empty attributed string to `UITextField`, now if the length is 0, we just nil the `attributedText` instead.

## Changelog

[iOS] [Fixed] - Don't apply empty attributed string for TextInput
Pull Request resolved: https://github.com/facebook/react-native/pull/25143

Differential Revision: D15661751

Pulled By: sammy-SC

fbshipit-source-id: 9770484a1b68a6409e63ea25ac9a6fd0d3589b14
2019-06-06 09:17:16 -07:00
..
Multiline
Fixed accesibility problem with <TextInput>'s Clear Button
2019-05-09 12:25:06 -07:00
Singleline
Resubmit #24714 and fixes kvo crash (#24840)
2019-05-20 22:31:45 -07:00
RCTBackedTextInputDelegate.h
Fixed onScroll prop in mulitline TextInput (#23668)
2019-02-27 18:26:27 -08:00
RCTBackedTextInputDelegateAdapter.h
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
RCTBackedTextInputDelegateAdapter.m
Back out "[react-native][PR] [iOS] Fixes selection of single line text input"
2019-05-13 13:18:20 -07:00
RCTBackedTextInputViewProtocol.h
Fix textAttributes not applied when typing text (#23585)
2019-02-24 23:37:41 -08:00
RCTBaseTextInputShadowView.h
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
RCTBaseTextInputShadowView.m
Don't apply empty attributed string for TextInput (#25143)
2019-06-06 09:17:16 -07:00
RCTBaseTextInputView.h
Don't apply empty attributed string for TextInput (#25143)
2019-06-06 09:17:16 -07:00
RCTBaseTextInputView.m
Fixes text style lost when enable maxLength (#24989)
2019-05-31 02:18:15 -07:00
RCTBaseTextInputViewManager.h
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
RCTBaseTextInputViewManager.m
Revert accessibility textinput issue to see if it is the root cause of labels not showing up properly
2019-05-08 21:16:21 -07:00
RCTInputAccessoryShadowView.h
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
RCTInputAccessoryShadowView.m
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
RCTInputAccessoryView.h
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
RCTInputAccessoryView.m
Fix InputAccessoryView safe area when not attached to a TextInput (#21179)
2018-09-18 18:31:51 -07:00
RCTInputAccessoryViewContent.h
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
RCTInputAccessoryViewContent.m
Fix InputAccessoryView safe area when not attached to a TextInput (#21179)
2018-09-18 18:31:51 -07:00
RCTInputAccessoryViewManager.h
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
RCTInputAccessoryViewManager.m
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
RCTTextSelection.h
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00
RCTTextSelection.m
Update copyright headers to yearless format
2018-09-11 15:33:07 -07:00