mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Rick Hanlon
504fc0c7d0
Summary:
This diff updated the codegen flow types syntax replacing:
```
type Options = {
isDeprecatedPaperComponentNameRCT: true,
};
type ActivityIndicatorNativeType = CodegenNativeComponent<
'ActivityIndicatorView',
NativeProps,
Options,
>;
module.exports = ((requireNativeComponent(
'RCTActivityIndicatorView',
): any): ActivityIndicatorNativeType);
```
with:
```
export default codegenNativeComponent<NativeProps>('ActivityIndicatorView', {
isDeprecatedPaperComponentNameRCT: true,
});
```
This is from Tim's comment in the [View Config Codegen Quip](https://fb.quip.com/jR2aASHad4Se):
> What it CodegenNativeComponent were instead `NativeComponent.fromFlow<T>('…')` that returned `'...'`?
>And the Babel plugin swapped it for NativeComponent.fromSchema('...', {…}) which would both register and return '...'?
I went with `codegenNativeComponent` because it has nice parity with `requireNativeComponent`
I also didn't update the babel output here (we can update that whenever) because I think `registerGeneratedViewConfig` is more clear for what it's doing
Reviewed By: cpojer
Differential Revision: D15602077
fbshipit-source-id: 2d24dc32136ba6d31724f8c929b51417ba625a58
56 lines
1.5 KiB
JavaScript
56 lines
1.5 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
* @flow
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
import type {WithDefault} from '../../Types/CodegenTypes';
|
|
|
|
import type {ColorValue} from '../../StyleSheet/StyleSheetTypes';
|
|
import type {ViewProps} from '../View/ViewPropTypes';
|
|
|
|
import codegenNativeComponent from '../../Utilities/codegenNativeComponent';
|
|
|
|
type NativeProps = $ReadOnly<{|
|
|
...ViewProps,
|
|
|
|
/**
|
|
* Whether the indicator should hide when not animating (true by default).
|
|
*
|
|
* See http://facebook.github.io/react-native/docs/activityindicator.html#hideswhenstopped
|
|
*/
|
|
hidesWhenStopped?: ?WithDefault<boolean, false>,
|
|
|
|
/**
|
|
* Whether to show the indicator (true, the default) or hide it (false).
|
|
*
|
|
* See http://facebook.github.io/react-native/docs/activityindicator.html#animating
|
|
*/
|
|
animating?: ?WithDefault<boolean, false>,
|
|
|
|
/**
|
|
* The foreground color of the spinner (default is gray).
|
|
*
|
|
* See http://facebook.github.io/react-native/docs/activityindicator.html#color
|
|
*/
|
|
color?: ?ColorValue,
|
|
|
|
/**
|
|
* Size of the indicator (default is 'small').
|
|
* Passing a number to the size prop is only supported on Android.
|
|
*
|
|
* See http://facebook.github.io/react-native/docs/activityindicator.html#size
|
|
*/
|
|
size?: ?WithDefault<'small' | 'large', 'small'>,
|
|
|}>;
|
|
|
|
export default codegenNativeComponent<NativeProps>('ActivityIndicatorView', {
|
|
isDeprecatedPaperComponentNameRCT: true,
|
|
});
|