mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Bruno AybarandReact Native Bot
97adbd897f
Summary: Fixes https://github.com/facebook/react-native/issues/49819 . Details about how the issue was introduced in the issue description. bypass-github-export-checks ## Changelog: [IOS] [FIXED] - Fixed: extraModulesForBridge callback not called when New Architecture enabled <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests Pull Request resolved: https://github.com/facebook/react-native/pull/49849 Test Plan: Without the change: 1. Open `packages/rn-tester` project 2. In `AppDelegate.mm`, implement `extraModulesForBridge` and add a breakpoint / output something 3. Run the app in iOS <-- Verify that the method is not executed With the change: 1-3. Same as above <-- verify that the method is called correctly > [!NOTE] > As far as I could tell, there is no test suite for this specific codepath, so I didn't write a test for this change. Happy to write one if someone can guide me a little bit. Reviewed By: rshest Differential Revision: D70724196 Pulled By: cipolleschi fbshipit-source-id: cc08798d08cdbd6883347810c7d2697c358770fb