Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
9419bebb9857f1ea39f248769003bfdfd4218a8a
react-native/ReactCommon/react/renderer/components/text
T
History
Samuel SuslaandFacebook GitHub Bot bcc4ab35da Remove use of TextLayoutManager::Shared and SharedTextLayoutManager 
Summary:
changelog: [internal]

For some reason, using `TextLayoutManager::Shared` in `TextInputShadowNode` trips up clang tidy linter. We have a plan to move away from `*::Shared` anyway, so let's remove it from `TextInputShadowNode` now.

Why do we want to move away from `*::Shared`?
Using `TextLayoutManager::Shared` is confusing for people unfamiliar with Fabric's codebase. It expresses a concept of immutability but uses term `shared`. Term shared is already used in C++  `std::shared_ptr`.

Reviewed By: fkgozali

Differential Revision: D33186422

fbshipit-source-id: 10ee588735997f5fedc372a1d1e3d9cd9684178a
2021-12-22 04:20:42 -08:00
..
tests
ReactCommon/renderer/components/text: Migrate uses of NDEBUG to REACT_NATIVE_DEBUG + react_native_assert
2021-02-26 23:29:59 -08:00
Android.mk
Update LOCAL_SHARED_LIBRARIES to be a multiline string
2021-11-29 13:01:51 -08:00
BaseTextProps.cpp
Merge textDecoration(LineStyle|LinePattern) into textDecorationStyle
2021-10-18 02:16:03 -07:00
BaseTextProps.h
Pass context through to all prop parser (props structs changes)
2021-07-28 20:18:20 -07:00
BaseTextShadowNode.cpp
Daily arc lint --take CLANGFORMAT
2021-06-14 04:19:36 -07:00
BaseTextShadowNode.h
Move Text C++ out of inner folders
2020-08-18 19:55:50 -07:00
BUCK
Remove compiler_flags from BUCK modules
2021-10-14 15:34:29 -07:00
conversions.h
Implement and integrate Mapbuffer
2021-03-24 03:52:31 -07:00
ParagraphComponentDescriptor.h
Remove use of TextLayoutManager::Shared and SharedTextLayoutManager
2021-12-22 04:20:42 -08:00
ParagraphEventEmitter.cpp
Prevent calling onTextLayout with the same value
2020-09-20 08:18:55 -07:00
ParagraphEventEmitter.h
Prevent calling onTextLayout with the same value
2020-09-20 08:18:55 -07:00
ParagraphProps.cpp
Pass context through to all prop parser (props structs changes)
2021-07-28 20:18:20 -07:00
ParagraphProps.h
Pass context through to all prop parser (props structs changes)
2021-07-28 20:18:20 -07:00
ParagraphShadowNode.cpp
Remove use of TextLayoutManager::Shared and SharedTextLayoutManager
2021-12-22 04:20:42 -08:00
ParagraphShadowNode.h
Remove use of TextLayoutManager::Shared and SharedTextLayoutManager
2021-12-22 04:20:42 -08:00
ParagraphState.cpp
Implement and integrate Mapbuffer
2021-03-24 03:52:31 -07:00
ParagraphState.h
Implement and integrate Mapbuffer
2021-03-24 03:52:31 -07:00
RawTextComponentDescriptor.h
Move Text C++ out of inner folders
2020-08-18 19:55:50 -07:00
RawTextProps.cpp
Pass context through to all prop parser (props structs changes)
2021-07-28 20:18:20 -07:00
RawTextProps.h
Pass context through to all prop parser (props structs changes)
2021-07-28 20:18:20 -07:00
RawTextShadowNode.cpp
Move Text C++ out of inner folders
2020-08-18 19:55:50 -07:00
RawTextShadowNode.h
Remove usages of dynamic_casts that are used inside assertions
2021-08-24 09:53:04 -07:00
TextComponentDescriptor.h
Move Text C++ out of inner folders
2020-08-18 19:55:50 -07:00
TextProps.cpp
Pass context through to all prop parser (props structs changes)
2021-07-28 20:18:20 -07:00
TextProps.h
Pass context through to all prop parser (props structs changes)
2021-07-28 20:18:20 -07:00
TextShadowNode.cpp
Move Text C++ out of inner folders
2020-08-18 19:55:50 -07:00
TextShadowNode.h
Remove usages of dynamic_casts that are used inside assertions
2021-08-24 09:53:04 -07:00