Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
92a3dff58ab062acf4cd5eefaba8ac67a835cbc2
react-native/Libraries/Image
T
History
Paito Anderson 0bcc686c1c Fix iOS Image.getSizeWithHeaders (#29338) 
Summary:
Fixes https://github.com/facebook/react-native/issues/28632

Image.getSizeWithHeaders() was not working as intended on iOS.

## Changelog

[iOS] [Fixed] - Fixed headers in `Image.getSizeWithHeaders`.

Pull Request resolved: https://github.com/facebook/react-native/pull/29338

Test Plan:
Used RNTester and an Image URL requiring a Bearer token to test.

Code:
<img width="720" alt="Screen Shot 2020-07-10 at 3 00 58 PM" src="https://user-images.githubusercontent.com/4108718/87189376-850cba00-c2be-11ea-851c-d9fa37d88de4.png">

With Bearer Token:
<img width="456" alt="Screen Shot 2020-07-10 at 3 02 48 PM" src="https://user-images.githubusercontent.com/4108718/87189349-7de5ac00-c2be-11ea-8d82-c74cae6d904b.png">

Without Bearer Token:
<img width="559" alt="Screen Shot 2020-07-10 at 3 04 32 PM" src="https://user-images.githubusercontent.com/4108718/87189458-aff70e00-c2be-11ea-82b7-34a14ec465f1.png">

Reviewed By: cpojer

Differential Revision: D22783037

Pulled By: PeteTheHeat

fbshipit-source-id: 3ad5026e71607c61d42316784844c5295bc1dcae
2020-07-28 13:16:28 -07:00
..
__tests__
Add @react-native/assets package for Asset Registry related code
2020-07-23 05:07:40 -07:00
AssetRegistry.js
Add @react-native/assets package for Asset Registry related code
2020-07-23 05:07:40 -07:00
AssetSourceResolver.js
Add @react-native/assets package for Asset Registry related code
2020-07-23 05:07:40 -07:00
Image.android.js
Rename analyticsTag -> internal_analyticsTag in ImageView component
2020-04-07 17:39:21 -07:00
Image.ios.js
Annotate <Image> components in QPL logging using ImageAnalyticsTagContext
2020-05-23 23:40:24 -07:00
ImageAnalyticsTagContext.js
Fix flow types of ImageContext
2020-04-07 17:39:21 -07:00
ImageBackground.js
Back out "Upgrade Prettier from 1.17 to 2.0.2."
2020-03-24 21:47:35 -07:00
ImagePickerIOS.js
Back out "Upgrade Prettier from 1.17 to 2.0.2."
2020-03-24 21:47:35 -07:00
ImageProps.js
RN: Consistent API for Image Events
2020-06-16 15:01:05 -07:00
ImageResizeMode.js
RN: Replace ImageResizeMode w/ Flow Type
2018-09-28 01:07:30 -07:00
ImageSource.js
Exact-by-default codemod for react-native-github
2019-11-21 09:42:57 -08:00
ImageViewNativeComponent.js
Make ColorValue public in StyleSheet.js
2020-04-17 13:03:47 -07:00
ImageViewViewConfig.js
Deploy Flow v0.116 to xplat
2020-01-16 14:05:49 -08:00
NativeImageEditor.js
Migrate large amount of modules to flow strict and strict-local
2020-07-22 09:46:16 -07:00
NativeImageLoaderAndroid.js
Exact-by-default codemod for react-native-github
2019-11-21 09:42:57 -08:00
NativeImageLoaderIOS.js
Exact-by-default codemod for react-native-github
2019-11-21 09:42:57 -08:00
NativeImagePickerIOS.js
Migrate large amount of modules to flow strict and strict-local
2020-07-22 09:46:16 -07:00
nativeImageSource.js
Updating the URLs to point at new domain name reactnative.dev
2020-02-24 13:09:11 -08:00
NativeImageStore.js
Migrate large amount of modules to flow strict and strict-local
2020-07-22 09:46:16 -07:00
RCTAnimatedImage.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTAnimatedImage.m
fbshipit-source-id: da15f69185e724eaf7d4bc78dbc61fcdcb3074d5
2020-03-13 21:46:45 -07:00
RCTDisplayWeakRefreshable.h
iOS: Fix Animated image crash when CADisplayLink target in RCTWeakProxy is nil
2020-05-12 17:08:43 -07:00
RCTDisplayWeakRefreshable.m
iOS: Fix Animated image crash when CADisplayLink target in RCTWeakProxy is nil
2020-05-12 17:08:43 -07:00
RCTGIFImageDecoder.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTGIFImageDecoder.mm
Make RCTLocalAssetImageLoader and RCTGIFImageDecoder TurboModule-compatible
2019-10-21 17:15:33 -07:00
RCTImageBlurUtils.h
Tidy up license headers [3/n]
2019-10-16 10:06:34 -07:00
RCTImageBlurUtils.m
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTImageCache.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTImageCache.m
Remove unneeded NSNotification center removeObserver
2019-11-04 10:19:30 -08:00
RCTImageDataDecoder.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTImageEditingManager.h
Move RCTImage NativeModules back to RCTImage
2019-10-21 17:15:32 -07:00
RCTImageEditingManager.mm
Part 2: Update ObjC++ codegen classes to use ObjCTurboModule::InitParams
2020-04-16 17:29:55 -07:00
RCTImageLoader.h
iOS Fabric: added support for image instrumentation [1]
2019-12-16 22:50:44 -08:00
RCTImageLoader.mm
Fix iOS Image.getSizeWithHeaders (#29338)
2020-07-28 13:16:28 -07:00
RCTImageLoaderProtocol.h
Remove requestToken being nil check from [RCTNetworkTask validateRequestToken]
2020-07-28 12:00:57 -07:00
RCTImageLoaderWithAttributionProtocol.h
Prefetch images using a lower download priority
2020-06-05 20:55:36 -07:00
RCTImagePlugins.h
Run depslint on fb_plugin_apple_library rules
2019-10-26 13:47:15 -07:00
RCTImagePlugins.mm
Make RCTLocalAssetImageLoader and RCTGIFImageDecoder TurboModule-compatible
2019-10-21 17:15:33 -07:00
RCTImageShadowView.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTImageShadowView.m
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTImageStoreManager.h
Move RCTImage NativeModules back to RCTImage
2019-10-21 17:15:32 -07:00
RCTImageStoreManager.mm
Part 2: Update ObjC++ codegen classes to use ObjCTurboModule::InitParams
2020-04-16 17:29:55 -07:00
RCTImageURLLoader.h
Remove requestToken being nil check from [RCTNetworkTask validateRequestToken]
2020-07-28 12:00:57 -07:00
RCTImageURLLoaderWithAttribution.h
Prefetch images using a lower download priority
2020-06-05 20:55:36 -07:00
RCTImageURLLoaderWithAttribution.mm
iOS Fabric: added support for image instrumentation [2]
2019-12-16 22:50:45 -08:00
RCTImageUtils.h
Tidy up license headers [3/n]
2019-10-16 10:06:34 -07:00
RCTImageUtils.m
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTImageView.h
Annotate <Image> components in QPL logging using ImageAnalyticsTagContext
2020-05-23 23:40:24 -07:00
RCTImageView.mm
RN: Consistent API for Image Events
2020-06-16 15:01:05 -07:00
RCTImageViewManager.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTImageViewManager.mm
Prefetch images using a lower download priority
2020-06-05 20:55:36 -07:00
RCTLocalAssetImageLoader.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTLocalAssetImageLoader.mm
Remove requestToken being nil check from [RCTNetworkTask validateRequestToken]
2020-07-28 12:00:57 -07:00
RCTResizeMode.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTResizeMode.m
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTUIImageViewAnimated.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTUIImageViewAnimated.m
Hardcode @available(iOS 10) to YES
2020-07-22 11:00:32 -07:00
React-RCTImage.podspec
Fix Cocoapods builds
2020-04-07 19:07:19 -07:00
RelativeImageStub.js
Add @react-native/assets package for Asset Registry related code
2020-07-23 05:07:40 -07:00
resolveAssetSource.js
Add @react-native/assets package for Asset Registry related code
2020-07-23 05:07:40 -07:00
TextInlineImageNativeComponent.js
Introduce flow type to differentiate between HostComponent, NativeMethodsMixin, and NativeComponent
2019-09-25 10:12:38 -07:00