mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Andrei Shikov
1953f6f02e
Summary: With the `MapBuffer`-based props calculated from C++ props, there's no need to keep `rawProps` around for Android views. This change makes sure that the `rawProps` field is only initialized under the feature flag that is responsible for enabling `MapBuffer` for prop diffing, potentially decreasing memory footprint and speeding up node initialization as JS props don't have to be converted to `folly::dynamic` anymore. For layout animations, props rely on C++ values, so there's no need to update `rawProps` values either. Changelog: [Internal][Android] - Do not init `rawProps` when mapbuffer serialization is used for ViewProps. Reviewed By: mdvacca Differential Revision: D33793044 fbshipit-source-id: 35873b10d3ca8b152b25344ef2c27aff9641846f
434 lines
15 KiB
C++
434 lines
15 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <react/renderer/element/Element.h>
|
|
#include <react/renderer/element/testUtils.h>
|
|
|
|
#include "TestComponent.h"
|
|
|
|
using namespace facebook::react;
|
|
|
|
/*
|
|
* ┌────────┐
|
|
* │<View> │
|
|
* │ │
|
|
* │ ┌────┴───┐
|
|
* │ │<View> │
|
|
* └───┤ │
|
|
* │ │
|
|
* │ │
|
|
* └────────┘
|
|
*/
|
|
TEST(LayoutableShadowNodeTest, relativeLayoutMetrics) {
|
|
auto builder = simpleComponentBuilder();
|
|
|
|
auto childShadowNode = std::shared_ptr<ViewShadowNode>{};
|
|
// clang-format off
|
|
auto element =
|
|
Element<ViewShadowNode>()
|
|
.finalize([](ViewShadowNode &shadowNode){
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
layoutMetrics.frame.origin = {10, 20};
|
|
layoutMetrics.frame.size = {100, 200};
|
|
shadowNode.setLayoutMetrics(layoutMetrics);
|
|
})
|
|
.children({
|
|
Element<ViewShadowNode>()
|
|
.finalize([](ViewShadowNode &shadowNode){
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
layoutMetrics.frame.origin = {10, 20};
|
|
layoutMetrics.frame.size = {100, 200};
|
|
shadowNode.setLayoutMetrics(layoutMetrics);
|
|
})
|
|
.reference(childShadowNode)
|
|
});
|
|
// clang-format on
|
|
|
|
auto parentShadowNode = builder.build(element);
|
|
|
|
auto relativeLayoutMetrics =
|
|
LayoutableShadowNode::computeRelativeLayoutMetrics(
|
|
childShadowNode->getFamily(), *parentShadowNode, {});
|
|
|
|
// A is a parent to B, A has origin {10, 10}, B has origin {10, 10}.
|
|
// B's relative origin to A should be {10, 10}.
|
|
// D19447900 has more about the issue.
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.size.width, 100);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.size.height, 200);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.x, 10);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.y, 20);
|
|
}
|
|
|
|
/*
|
|
* ┌──────────────┐
|
|
* │<ScrollView> │
|
|
* │ ┌─────┴───┐
|
|
* │ │<View> │
|
|
* │ │ │
|
|
* └────────┤ │
|
|
* │ │
|
|
* └─────────┘
|
|
*/
|
|
TEST(LayoutableShadowNodeTest, contentOriginOffset) {
|
|
auto builder = simpleComponentBuilder();
|
|
|
|
auto childShadowNode = std::shared_ptr<ViewShadowNode>{};
|
|
// clang-format off
|
|
auto element =
|
|
Element<ScrollViewShadowNode>()
|
|
.finalize([](ScrollViewShadowNode &shadowNode){
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
layoutMetrics.frame.origin = {10, 20};
|
|
layoutMetrics.frame.size = {100, 200};
|
|
shadowNode.setLayoutMetrics(layoutMetrics);
|
|
})
|
|
.stateData([](ScrollViewState &data) {
|
|
data.contentOffset = {10, 10};
|
|
})
|
|
.children({
|
|
Element<ViewShadowNode>()
|
|
.finalize([](ViewShadowNode &shadowNode){
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
layoutMetrics.frame.origin = {10, 20};
|
|
layoutMetrics.frame.size = {100, 200};
|
|
shadowNode.setLayoutMetrics(layoutMetrics);
|
|
})
|
|
.reference(childShadowNode)
|
|
});
|
|
// clang-format on
|
|
|
|
auto parentShadowNode = builder.build(element);
|
|
|
|
auto relativeLayoutMetrics =
|
|
LayoutableShadowNode::computeRelativeLayoutMetrics(
|
|
childShadowNode->getFamily(), *parentShadowNode, {});
|
|
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.x, 0);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.y, 10);
|
|
|
|
relativeLayoutMetrics = LayoutableShadowNode::computeRelativeLayoutMetrics(
|
|
childShadowNode->getFamily(), *parentShadowNode, {false});
|
|
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.x, 10);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.y, 20);
|
|
}
|
|
|
|
/*
|
|
* ┌────────────────────────┐
|
|
* │<View> │
|
|
* │ ┌────────────────┐│
|
|
* │ │<View> ││
|
|
* │ │ ││
|
|
* │ └────────────────┘│
|
|
* └────────────────────────┘
|
|
*/
|
|
TEST(LayoutableShadowNodeTest, relativeLayoutMetricsOnTransformedNode) {
|
|
auto builder = simpleComponentBuilder();
|
|
|
|
auto childShadowNode = std::shared_ptr<ViewShadowNode>{};
|
|
// clang-format off
|
|
auto element =
|
|
Element<ViewShadowNode>()
|
|
.finalize([](ViewShadowNode &shadowNode){
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
layoutMetrics.frame.size = {1000, 1000};
|
|
shadowNode.setLayoutMetrics(layoutMetrics);
|
|
})
|
|
.children({
|
|
Element<ViewShadowNode>()
|
|
.finalize([](ViewShadowNode &shadowNode){
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
layoutMetrics.frame.origin = {10, 20};
|
|
layoutMetrics.frame.size = {100, 200};
|
|
shadowNode.setLayoutMetrics(layoutMetrics);
|
|
})
|
|
.props([] {
|
|
auto sharedProps = std::make_shared<ViewShadowNodeProps>();
|
|
sharedProps->transform = Transform::Scale(0.5, 0.5, 1);
|
|
return sharedProps;
|
|
})
|
|
.reference(childShadowNode)
|
|
});
|
|
// clang-format on
|
|
|
|
auto parentShadowNode = builder.build(element);
|
|
|
|
auto relativeLayoutMetrics =
|
|
LayoutableShadowNode::computeRelativeLayoutMetrics(
|
|
childShadowNode->getFamily(), *parentShadowNode, {});
|
|
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.x, 35);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.y, 70);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.size.width, 50);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.size.height, 100);
|
|
}
|
|
|
|
/*
|
|
* ┌────────────────────────┐
|
|
* │<Root> │
|
|
* │ ┌─────────────────────┐│
|
|
* │ │ <View> ││
|
|
* │ │ ┌──────────────┐││
|
|
* │ │ │<View> │││
|
|
* │ │ │ ┌──────────┐│││
|
|
* │ │ │ │<View> ││││
|
|
* │ │ │ │ ││││
|
|
* │ │ │ │ ││││
|
|
* │ │ │ └──────────┘│││
|
|
* │ │ └──────────────┘││
|
|
* │ └─────────────────────┘│
|
|
* └────────────────────────┘
|
|
*/
|
|
TEST(LayoutableShadowNodeTest, relativeLayoutMetricsOnTransformedParent) {
|
|
auto builder = simpleComponentBuilder();
|
|
|
|
auto childShadowNode = std::shared_ptr<ViewShadowNode>{};
|
|
// clang-format off
|
|
auto element =
|
|
Element<RootShadowNode>()
|
|
.finalize([](RootShadowNode &shadowNode){
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
layoutMetrics.frame.size = {900, 900};
|
|
shadowNode.setLayoutMetrics(layoutMetrics);
|
|
})
|
|
.children({
|
|
Element<ViewShadowNode>()
|
|
.props([] {
|
|
auto sharedProps = std::make_shared<ViewShadowNodeProps>();
|
|
sharedProps->transform = Transform::Scale(0.5, 0.5, 1);
|
|
return sharedProps;
|
|
})
|
|
.finalize([](ViewShadowNode &shadowNode){
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
layoutMetrics.frame.origin = {10, 10};
|
|
layoutMetrics.frame.size = {100, 100};
|
|
shadowNode.setLayoutMetrics(layoutMetrics);
|
|
})
|
|
.children({
|
|
Element<ViewShadowNode>()
|
|
.reference(childShadowNode)
|
|
.finalize([](ViewShadowNode &shadowNode){
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
layoutMetrics.frame.origin = {10, 10};
|
|
layoutMetrics.frame.size = {50, 50};
|
|
shadowNode.setLayoutMetrics(layoutMetrics);
|
|
})
|
|
})
|
|
});
|
|
// clang-format on
|
|
|
|
auto parentShadowNode = builder.build(element);
|
|
|
|
auto relativeLayoutMetrics =
|
|
LayoutableShadowNode::computeRelativeLayoutMetrics(
|
|
childShadowNode->getFamily(), *parentShadowNode, {});
|
|
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.x, 45);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.y, 45);
|
|
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.size.width, 25);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.size.height, 25);
|
|
}
|
|
|
|
/*
|
|
* ┌────────────────┐
|
|
* │<View> │
|
|
* │ │
|
|
* └────────────────┘
|
|
*/
|
|
TEST(LayoutableShadowNodeTest, relativeLayoutMetricsOnSameNode) {
|
|
auto builder = simpleComponentBuilder();
|
|
|
|
// clang-format off
|
|
auto element =
|
|
Element<ViewShadowNode>()
|
|
.finalize([](ViewShadowNode &shadowNode){
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
layoutMetrics.frame.size = {100, 200};
|
|
layoutMetrics.frame.origin = {10, 20};
|
|
shadowNode.setLayoutMetrics(layoutMetrics);
|
|
});
|
|
// clang-format on
|
|
|
|
auto shadowNode = builder.build(element);
|
|
|
|
auto relativeLayoutMetrics =
|
|
LayoutableShadowNode::computeRelativeLayoutMetrics(
|
|
shadowNode->getFamily(), *shadowNode, {});
|
|
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.x, 0);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.y, 0);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.size.width, 100);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.size.height, 200);
|
|
}
|
|
|
|
/*
|
|
* ┌────────────────┐
|
|
* │<View> │
|
|
* │ │
|
|
* └────────────────┘
|
|
*/
|
|
TEST(LayoutableShadowNodeTest, relativeLayoutMetricsOnSameTransformedNode) {
|
|
auto builder = simpleComponentBuilder();
|
|
|
|
// clang-format off
|
|
auto element =
|
|
Element<ViewShadowNode>()
|
|
.props([] {
|
|
auto sharedProps = std::make_shared<ViewShadowNodeProps>();
|
|
sharedProps->transform = Transform::Scale(2, 2, 1);
|
|
return sharedProps;
|
|
})
|
|
.finalize([](ViewShadowNode &shadowNode){
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
layoutMetrics.frame.size = {100, 200};
|
|
layoutMetrics.frame.origin = {10, 20};
|
|
shadowNode.setLayoutMetrics(layoutMetrics);
|
|
});
|
|
// clang-format on
|
|
|
|
auto shadowNode = builder.build(element);
|
|
|
|
auto relativeLayoutMetrics =
|
|
LayoutableShadowNode::computeRelativeLayoutMetrics(
|
|
shadowNode->getFamily(), *shadowNode, {});
|
|
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.x, 0);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.y, 0);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.size.width, 200);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.size.height, 400);
|
|
}
|
|
|
|
/*
|
|
* ┌────────────────────────┐
|
|
* │<View> │
|
|
* │ ┌────────────────┐│
|
|
* │ │<View> ││
|
|
* │ │ ││
|
|
* │ └────────────────┘│
|
|
* └────────────────────────┘
|
|
*/
|
|
TEST(LayoutableShadowNodeTest, relativeLayourMetricsOnClonedNode) {
|
|
auto builder = simpleComponentBuilder();
|
|
|
|
auto childShadowNode = std::shared_ptr<ViewShadowNode>{};
|
|
|
|
// clang-format off
|
|
auto element =
|
|
Element<ViewShadowNode>()
|
|
.children({
|
|
Element<ViewShadowNode>()
|
|
.reference(childShadowNode)
|
|
});
|
|
// clang-format on
|
|
|
|
auto parentShadowNode = builder.build(element);
|
|
|
|
auto clonedChildShadowNode =
|
|
std::static_pointer_cast<ViewShadowNode>(childShadowNode->clone({}));
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
layoutMetrics.frame.size = {50, 60};
|
|
clonedChildShadowNode->setLayoutMetrics(layoutMetrics);
|
|
|
|
parentShadowNode->replaceChild(*childShadowNode, clonedChildShadowNode);
|
|
|
|
auto newRelativeLayoutMetrics =
|
|
LayoutableShadowNode::computeRelativeLayoutMetrics(
|
|
childShadowNode->getFamily(), *parentShadowNode, {});
|
|
EXPECT_EQ(newRelativeLayoutMetrics.frame.size.width, 50);
|
|
EXPECT_EQ(newRelativeLayoutMetrics.frame.size.height, 60);
|
|
}
|
|
|
|
/*
|
|
* ┌─────────────────────────┐
|
|
* │<View> │
|
|
* │ ┌──────────────────────┐│
|
|
* │ │<Modal> ││
|
|
* │ │ ┌───────────┐ ││
|
|
* │ │ │<View> │ ││
|
|
* │ │ │ │ ││
|
|
* │ │ └───────────┘ ││
|
|
* │ └──────────────────────┘│
|
|
* └─────────────────────────┘
|
|
*/
|
|
TEST(
|
|
LayoutableShadowNodeTest,
|
|
relativeLayoutMetricsOnNodesCrossingRootKindNode) {
|
|
auto builder = simpleComponentBuilder();
|
|
|
|
auto childShadowNode = std::shared_ptr<ViewShadowNode>{};
|
|
|
|
// clang-format off
|
|
auto element =
|
|
Element<ViewShadowNode>()
|
|
.children({
|
|
Element<ModalHostViewShadowNode>()
|
|
.finalize([](ModalHostViewShadowNode &shadowNode){
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
layoutMetrics.frame.origin = {10, 10};
|
|
shadowNode.setLayoutMetrics(layoutMetrics);
|
|
})
|
|
.children({
|
|
Element<ViewShadowNode>()
|
|
.reference(childShadowNode)
|
|
.finalize([](ViewShadowNode &shadowNode){
|
|
auto layoutMetrics = EmptyLayoutMetrics;
|
|
layoutMetrics.frame.origin = {10, 10};
|
|
shadowNode.setLayoutMetrics(layoutMetrics);
|
|
})
|
|
})
|
|
});
|
|
|
|
auto parentShadowNode = builder.build(element);
|
|
|
|
auto relativeLayoutMetrics = LayoutableShadowNode::computeRelativeLayoutMetrics(childShadowNode->getFamily(), *parentShadowNode, {});
|
|
|
|
// relativeLayoutMetrics do not include offsset of nodeAA_ because it is a
|
|
// RootKindNode.
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.x, 10);
|
|
EXPECT_EQ(relativeLayoutMetrics.frame.origin.y, 10);
|
|
}
|
|
|
|
TEST(LayoutableShadowNodeTest, includeViewportOffset) {
|
|
auto builder = simpleComponentBuilder();
|
|
|
|
auto viewShadowNode = std::shared_ptr<ViewShadowNode>{};
|
|
|
|
// clang-format off
|
|
auto element =
|
|
Element<RootShadowNode>()
|
|
.props([] {
|
|
auto sharedProps = std::make_shared<RootProps>();
|
|
sharedProps->layoutContext.viewportOffset = {10, 20};
|
|
return sharedProps;
|
|
})
|
|
.children({
|
|
Element<ViewShadowNode>()
|
|
.reference(viewShadowNode)
|
|
});
|
|
// clang-format on
|
|
|
|
auto rootShadowNode = builder.build(element);
|
|
|
|
// `includeViewportOffset` has to work with `includeTransform` enabled and
|
|
// disabled.
|
|
auto layoutMetrics = LayoutableShadowNode::computeRelativeLayoutMetrics(
|
|
viewShadowNode->getFamily(),
|
|
*rootShadowNode,
|
|
{/* includeTransform = */ false, /* includeViewportOffset = */ true});
|
|
EXPECT_EQ(layoutMetrics.frame.origin.x, 10);
|
|
EXPECT_EQ(layoutMetrics.frame.origin.y, 20);
|
|
|
|
layoutMetrics = LayoutableShadowNode::computeRelativeLayoutMetrics(
|
|
viewShadowNode->getFamily(),
|
|
*rootShadowNode,
|
|
{/* includeTransform = */ true, /* includeViewportOffset = */ true});
|
|
EXPECT_EQ(layoutMetrics.frame.origin.x, 10);
|
|
EXPECT_EQ(layoutMetrics.frame.origin.y, 20);
|
|
}
|