mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Saad Najmi
90327d9fba
Summary: Fixes https://github.com/facebook/react-native/issues/36097 When building RNTester with the old architecture, we skip a call to `build_codegen`, which will build the JS package at `packages/react-native-codegen`. This is needed for the Xcode Script phase `Generate Specs`. This causes a build with fabric disabled to fail. We can fix this by ensuring we call `build_codegen` in both paper and fabric. We've had this change in React Native macOS already since 0.68: https://github.com/microsoft/react-native-macos/commit/1175372ffecf6b4e18fa27b75b68f3ec7967a384 ## Changelog [IOS] [FIXED] - Build codegen package while using old architecture Pull Request resolved: https://github.com/facebook/react-native/pull/36098 Test Plan: CI should suffice. Locally built RN-Tester without fabric with and without my change to show that disabling fabric will only succeed with this change included. While running `pod install`, you should now see this extra line with the old architecture: > [Codegen] building ./../../packages/react-native-codegen. Reviewed By: cortinico Differential Revision: D43152692 Pulled By: cipolleschi fbshipit-source-id: 2cf3002f07eaad442ccb0272831fe2de58ec9c1a