mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Samuel SuslaandFacebook GitHub Bot
f9e4e246ff
Summary: Changelog: [Internal] # Problem We call `_state->updateState` anytime safe area insets changes. Once that is called, `_state` still holds old value, so when we check whether there is big enough of a difference, we are actually checking it against old value of state until `updateState` is called from MountingManager. This causes `_state->updateState` to be called dozens of times (I measured 47, with this diff it fell to 22) when displaying a safe area view inside Modal. # Solution Create new ivar `_lastPaddingStateWasUpdatedWith` where we store last padding that was sent through `_state->updateState` and compare new inset with this value instead of last value stored in state. Reviewed By: shergin Differential Revision: D21596367 fbshipit-source-id: b9249b8ef444ea532ec8b86a15a32c733eb6f987