mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Vojtech Novak
884c86ae02
Summary: I propose this change because we (and a lot of other people, I'd guess) pass an `async` function as a parameter to `onRefresh`. Because the `async` function returns a `promise`, flow is reporting an error. I think the type checking here can be relaxed either all the way to `any` (because RN does not care here what we return) or to `void | Promise<void>` to account for async functions. looking at https://github.com/facebook/react-native/commit/fb7b2d353356f67a3149c19ad733d46ec6842767#diff-a9c5687ae65236ba3e7f34bfdcdec81d seems like the second is preferred ## Changelog [General] [changed] - relax RefreshControl's onRefresh flow typing Pull Request resolved: https://github.com/facebook/react-native/pull/28167 Test Plan: * flow passes Reviewed By: hramos Differential Revision: D20196529 Pulled By: TheSavior fbshipit-source-id: bb5a314bcfb5fb9c8ab71eccb449f1322aeebacb