mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Kevin Gozali
1452954c4c
Summary: There are cases where the CallbackWrapper instances were added from different thread, potentially crashing the inner std::unordered_set<> we're using to keep the wrappers alive for extended time. To avoid it, let's just use std::mutex. Reviewed By: shergin Differential Revision: D17631233 fbshipit-source-id: e8f98004e45a68be31f8f0cda118fb67dcb06d45
57 lines
1.4 KiB
C++
57 lines
1.4 KiB
C++
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <memory>
|
|
#include <mutex>
|
|
#include <unordered_set>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
/**
|
|
* A simple wrapper class that can be registered to a collection that keep it
|
|
* alive for extended period of time. This object can be removed from the
|
|
* collection when needed.
|
|
*
|
|
* The subclass of this class must be created using std::make_shared<T>().
|
|
* After creation, add it to the `LongLivedObjectCollection`.
|
|
* When done with the object, call `allowRelease()` to allow the OS to release
|
|
* it.
|
|
*/
|
|
class LongLivedObject {
|
|
public:
|
|
void allowRelease();
|
|
|
|
protected:
|
|
LongLivedObject();
|
|
};
|
|
|
|
/**
|
|
* A singleton, thread-safe, write-only collection for the `LongLivedObject`s.
|
|
*/
|
|
class LongLivedObjectCollection {
|
|
public:
|
|
static LongLivedObjectCollection &get();
|
|
|
|
LongLivedObjectCollection(LongLivedObjectCollection const &) = delete;
|
|
void operator=(LongLivedObjectCollection const &) = delete;
|
|
|
|
void add(std::shared_ptr<LongLivedObject> o) const;
|
|
void remove(const LongLivedObject *o) const;
|
|
void clear() const;
|
|
|
|
private:
|
|
LongLivedObjectCollection();
|
|
mutable std::unordered_set<std::shared_ptr<LongLivedObject>> collection_;
|
|
mutable std::mutex collectionMutex_;
|
|
};
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|