mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Peter Argany
a6a6dbe05c
Summary:
This diff adds nuance to timer creation. Imagine the following bit of JS:
```
setTimeout(() => {
console.log("Timeout")
}, 0);
setImmediate(() => {
setNine("Immediate");
});
```
In classic RN, `setTimeout` will be called async by the bridge, immediate is implemented in JS, so the ordering of logs will be:
1. Immediate
2. Timeout
In bridgeless RN `setTimeout` is called sync, so the ordering of the logs is:
1. Timeout
2. Immediate
In order to preserve ordering, this diff adds a timer creation method which doesn't immediately invoke it, but waits one frame to do so.
This PR does the same thing for android, and explains the reasoning for preserving behaviour (some products may rely on this behaviour) https://github.com/facebook/react-native/commit/f054928124a2308b2bd450acf8bb754a92ccb16a
Reviewed By: ejanzer
Differential Revision: D17535639
fbshipit-source-id: 3f734c420a6a95be2ee10e8d6ac48adc79ef1c96
33 lines
985 B
Objective-C
33 lines
985 B
Objective-C
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import <Foundation/Foundation.h>
|
|
|
|
#import <React/RCTBridgeModule.h>
|
|
#import <React/RCTFrameUpdate.h>
|
|
#import <React/RCTInvalidating.h>
|
|
|
|
@protocol RCTTimingDelegate
|
|
|
|
- (void)callTimers:(NSArray<NSNumber *> *)timers;
|
|
- (void)immediatelyCallTimer:(nonnull NSNumber *)callbackID;
|
|
- (void)callIdleCallbacks:(nonnull NSNumber *)absoluteFrameStartMS;
|
|
|
|
@end
|
|
|
|
@interface RCTTiming : NSObject <RCTBridgeModule, RCTInvalidating, RCTFrameUpdateObserver>
|
|
|
|
- (instancetype)initWithDelegate:(id<RCTTimingDelegate>) delegate;
|
|
- (void)createTimerForNextFrame:(nonnull NSNumber *)callbackID
|
|
duration:(NSTimeInterval)jsDuration
|
|
jsSchedulingTime:(NSDate *)jsSchedulingTime
|
|
repeats:(BOOL)repeats;
|
|
- (void)deleteTimer:(nonnull NSNumber *)timerID;
|
|
|
|
@end
|
|
|