mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
jeswinsimon
20ab946f34
Summary: Fix for https://github.com/facebook/react-native/issues/26019 URL cannot handle "localhost" domain for base url. Also noticed another issue where `/` is not added between base URL and path if it is missing. Added fix for that too. ## Changelog [Javascript] [Fixed] - `URL`: Bare Hosts are now supported. Pull Request resolved: https://github.com/facebook/react-native/pull/26050 Test Plan: * `new URL('home', 'http://localhost')` now returns `http://localhost/home` instead of throwing an error. * `new URL('en-US/docs', 'https://developer.mozilla.org')` now returns `https://developer.mozilla.org/en-US/docs` and not `https://developer.mozilla.orgen-US/docs`. Differential Revision: D17314137 Pulled By: cpojer fbshipit-source-id: ef56c4f4032187a7efee32b28e2b3c935b6a2599
44 lines
1.7 KiB
JavaScript
44 lines
1.7 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
* @emails oncall+react_native
|
|
*/
|
|
'use strict';
|
|
|
|
const URL = require('../URL').URL;
|
|
|
|
describe('URL', function() {
|
|
it('should pass Mozilla Dev Network examples', () => {
|
|
const a = new URL('/', 'https://developer.mozilla.org');
|
|
expect(a.href).toBe('https://developer.mozilla.org/');
|
|
const b = new URL('https://developer.mozilla.org');
|
|
expect(b.href).toBe('https://developer.mozilla.org/');
|
|
const c = new URL('en-US/docs', b);
|
|
expect(c.href).toBe('https://developer.mozilla.org/en-US/docs');
|
|
const d = new URL('/en-US/docs', b);
|
|
expect(d.href).toBe('https://developer.mozilla.org/en-US/docs');
|
|
const f = new URL('/en-US/docs', d);
|
|
expect(f.href).toBe('https://developer.mozilla.org/en-US/docs');
|
|
// from original test suite, but requires complex implementation
|
|
// const g = new URL(
|
|
// '/en-US/docs',
|
|
// 'https://developer.mozilla.org/fr-FR/toto',
|
|
// );
|
|
// expect(g.href).toBe('https://developer.mozilla.org/en-US/docs');
|
|
const h = new URL('/en-US/docs', a);
|
|
expect(h.href).toBe('https://developer.mozilla.org/en-US/docs');
|
|
const i = new URL('http://github.com', 'http://google.com');
|
|
expect(i.href).toBe('http://github.com/');
|
|
// Support Bare Hosts
|
|
const j = new URL('home', 'http://localhost');
|
|
expect(j.href).toBe('http://localhost/home');
|
|
// Insert / between Base and Path if missing
|
|
const k = new URL('en-US/docs', 'https://developer.mozilla.org');
|
|
expect(k.href).toBe('https://developer.mozilla.org/en-US/docs');
|
|
});
|
|
});
|