Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
85696298bf36203c94d586cf95f74e71a3c9d5d4
react-native/ReactCommon
T
History
Samuel Susla 85696298bf Fix yoga node owner getting out of sync with children 
Summary:
Changelog: [internal]

# Problem
We have node A with N children.

Calling cloning constructor on `YogaLayoutableShadowNode` causes new `yogaNode_` to be created.
However if `fragment.children` is nil in cloning constructor, which basically says children were not changed, then the existing children's `owner` becomes invalid.

# Solution
In the clone constructor, always call `updateYogaChildren`. This updates yoga children with the new `owner`.

Reviewed By: JoshuaGross

Differential Revision: D20139582

fbshipit-source-id: 3932694d4381b601df07dd8a57887ce7c09f1582
2020-02-28 06:17:55 -08:00
..
better
Run clang-format and apply patches
2020-02-27 08:29:30 -08:00
callinvoker
Unbreak the build
2020-02-20 08:30:46 -08:00
config
Run clang-format and apply patches
2020-02-27 08:29:30 -08:00
cxxreact
Run clang-format and apply patches
2020-02-27 08:29:30 -08:00
fabric
Fix yoga node owner getting out of sync with children
2020-02-28 06:17:55 -08:00
hermes
The life-changing magic of clang-tidying up
2020-02-04 11:09:30 -08:00
jscallinvoker
The life-changing magic of clang-tidying up
2020-02-04 11:09:30 -08:00
jsengineinstance
The life-changing magic of clang-tidying up
2020-02-04 11:09:30 -08:00
jsi
Codemod: Clang-format for all files in ReactCommon directory
2020-02-25 19:52:27 -08:00
jsiexecutor
Codemod: Clang-format for all files in ReactCommon directory
2020-02-25 19:52:27 -08:00
jsinspector
Codemod: Clang-format for all files in ReactCommon directory
2020-02-25 19:52:27 -08:00
microprofiler
Run clang-format and apply patches
2020-02-27 08:29:30 -08:00
turbomodule
Unbreak the build
2020-02-20 08:30:46 -08:00
utils
Run clang-format and apply patches
2020-02-27 08:29:30 -08:00
yoga
Make YGValue.h compile with Clang on Windows
2020-02-05 13:37:38 -08:00
common.mk
More robust hermes-engine lookup logic in makefiles (#26820)
2019-10-14 19:21:43 -07:00
React-Fabric.podspec
Updating the URLs to point at new domain name reactnative.dev
2020-02-24 13:09:11 -08:00
ReactCommon.podspec
Updating the URLs to point at new domain name reactnative.dev
2020-02-24 13:09:11 -08:00