mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Joshua Gross
7131791ab1
Summary: I am deduping a duplicated block, and adding comments to explain when we create INSERT/REMOVE mutations immediately and when we defer creation. Theoretically the ordering of mutations will be more consistent now, which ~shouldn't matter, but is probably a decent property to have. In particular, before, in some cases both of these orderings were possible in various scenarios: ``` INSERT X -> Y INSERT Y -> Z ``` and ``` INSERT Y -> Z INSERT X -> Y ``` Both of those are fine/correct/won't cause issues on any known platforms. But now, at least for the two cases touched here, only this ordering will be produced: ``` INSERT Y -> Z INSERT X -> Y ``` meaning we build the tree from the bottom-up (the "bottom" being the root) and do out-of-order inserts less frequently. Again, the biggest part of this diff should be readability/refactoring/de-duplicating logic, but more consistent orderings is a nice-to-have. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D28017926 fbshipit-source-id: 5941588d0c8bba8b0df7d0084d5d198f4b7c2427
146 lines
3.8 KiB
C++
146 lines
3.8 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <better/small_vector.h>
|
|
#include <folly/Hash.h>
|
|
#include <react/renderer/core/EventEmitter.h>
|
|
#include <react/renderer/core/LayoutMetrics.h>
|
|
#include <react/renderer/core/Props.h>
|
|
#include <react/renderer/core/ReactPrimitives.h>
|
|
#include <react/renderer/core/ShadowNode.h>
|
|
#include <react/renderer/debug/flags.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
/*
|
|
* Describes a view that can be mounted.
|
|
* This is exposed to the mounting layer.
|
|
*/
|
|
struct ShadowView final {
|
|
ShadowView() = default;
|
|
ShadowView(ShadowView const &shadowView) = default;
|
|
ShadowView(ShadowView &&shadowView) noexcept = default;
|
|
|
|
/*
|
|
* Constructs a `ShadowView` from given `ShadowNode`.
|
|
*/
|
|
explicit ShadowView(ShadowNode const &shadowNode);
|
|
|
|
ShadowView &operator=(ShadowView const &other) = default;
|
|
ShadowView &operator=(ShadowView &&other) = default;
|
|
|
|
bool operator==(ShadowView const &rhs) const;
|
|
bool operator!=(ShadowView const &rhs) const;
|
|
|
|
ComponentName componentName{};
|
|
ComponentHandle componentHandle{};
|
|
SurfaceId surfaceId{};
|
|
Tag tag{};
|
|
Props::Shared props{};
|
|
EventEmitter::Shared eventEmitter{};
|
|
LayoutMetrics layoutMetrics{EmptyLayoutMetrics};
|
|
State::Shared state{};
|
|
};
|
|
|
|
#if RN_DEBUG_STRING_CONVERTIBLE
|
|
|
|
std::string getDebugName(ShadowView const &object);
|
|
std::vector<DebugStringConvertibleObject> getDebugProps(
|
|
ShadowView const &object,
|
|
DebugStringConvertibleOptions options);
|
|
|
|
#endif
|
|
|
|
/*
|
|
* Describes pair of a `ShadowView` and a `ShadowNode`.
|
|
* This is not exposed to the mounting layer.
|
|
*
|
|
*/
|
|
struct ShadowViewNodePair final {
|
|
using NonOwningList = better::
|
|
small_vector<ShadowViewNodePair *, kShadowNodeChildrenSmallVectorSize>;
|
|
using OwningList = better::
|
|
small_vector<ShadowViewNodePair, kShadowNodeChildrenSmallVectorSize>;
|
|
|
|
ShadowView shadowView;
|
|
ShadowNode const *shadowNode;
|
|
bool flattened{false};
|
|
bool isConcreteView{true};
|
|
Point contextOrigin{0, 0};
|
|
|
|
size_t mountIndex{0};
|
|
|
|
/**
|
|
* This is nullptr unless `inOtherTree` is set to true.
|
|
* We rely on this only for marginal cases. TODO: could we
|
|
* rely on this more heavily to simplify the diffing algorithm
|
|
* overall?
|
|
*/
|
|
mutable ShadowViewNodePair const *otherTreePair{nullptr};
|
|
|
|
/*
|
|
* The stored pointer to `ShadowNode` represents an identity of the pair.
|
|
*/
|
|
bool operator==(const ShadowViewNodePair &rhs) const;
|
|
bool operator!=(const ShadowViewNodePair &rhs) const;
|
|
|
|
bool inOtherTree() const {
|
|
return this->otherTreePair != nullptr;
|
|
}
|
|
};
|
|
|
|
/*
|
|
* Describes pair of a `ShadowView` and a `ShadowNode`.
|
|
* This is not exposed to the mounting layer.
|
|
*
|
|
*/
|
|
struct ShadowViewNodePairLegacy final {
|
|
using OwningList = better::small_vector<
|
|
ShadowViewNodePairLegacy,
|
|
kShadowNodeChildrenSmallVectorSize>;
|
|
|
|
ShadowView shadowView;
|
|
ShadowNode const *shadowNode;
|
|
bool flattened{false};
|
|
bool isConcreteView{true};
|
|
|
|
size_t mountIndex{0};
|
|
|
|
bool inOtherTree{false};
|
|
|
|
/*
|
|
* The stored pointer to `ShadowNode` represents an identity of the pair.
|
|
*/
|
|
bool operator==(const ShadowViewNodePairLegacy &rhs) const;
|
|
bool operator!=(const ShadowViewNodePairLegacy &rhs) const;
|
|
};
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|
|
|
|
namespace std {
|
|
|
|
template <>
|
|
struct hash<facebook::react::ShadowView> {
|
|
size_t operator()(const facebook::react::ShadowView &shadowView) const {
|
|
return folly::hash::hash_combine(
|
|
0,
|
|
shadowView.surfaceId,
|
|
shadowView.componentHandle,
|
|
shadowView.tag,
|
|
shadowView.props,
|
|
shadowView.eventEmitter,
|
|
shadowView.layoutMetrics,
|
|
shadowView.state);
|
|
}
|
|
};
|
|
|
|
} // namespace std
|