mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Rick Hanlon
82db330360
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/43281 ## Overview This diff fixes a bug in the hermes component stack location parser, and fixes the hermes component stack tests which were not using hermes stack parsing, which is why the bug wasn't caught. The bug fix is that React component stacks may not all have stack frame locations. For example, this stack: ``` at MyComponent (/path/to/filename.js:1:2) at MyOtherComponent <-- no location at MyAppComponent (/path/to/app.js:100:20) ``` This can happen when we're unable to make a component throw (e.g. it doesn't use a hook or access props). We have plans to fix these frames, but currently they can exist. The bug was when `parseHermesStack` finds a frame without an `entry`, it would reset the `entries`. But if entries is already non-null, or if the current frame is a frame without a source, we should continue. ### Caveats The handling here fixes the behavior to go back to skipping these frames. I'm not sure what the best way to handle these cases are, since these frames do not have source location and should skip symbolication. We should follow up with handling for these frames. ## Why it wasn't caught In D18627930 we changed the hermes component stack parsing to check `global.HermesInternal`, but the tests for the hermes component stacks were still using the `stacktrace-parser`. I updated the tests to set/reset the global, which caught the bug. Changelog: [General][Fixed] - Support hermes component stacks with missing source info. Reviewed By: yungsters Differential Revision: D54423252 fbshipit-source-id: 80ded8b99eab919e60f847369dcb1f3afa72b6be