react-native

Facebook/react-native

Fork 0

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

History

Oleksandr MelnykovandFacebook Github Bot 92f3b4a27f Allow null as default value for float props

Summary:
Some props must have their default values set by native. To be able to support this, we have to introduce a null as a supported default value for some types. In this diff I'm adding support for null default values for float props. An example of this to be useful is `ReactDrawerLayoutManager`:

```
  Override
  public void setDrawerWidth(ReactDrawerLayout view, Nullable Float width) {
    int widthInPx =
        width == null
            ? LayoutParams.MATCH_PARENT
            : Math.round(PixelUtil.toPixelFromDIP(width));
    view.setDrawerWidth(widthInPx);
  }
```

We need to be able to generate an interface method, that accepts a boxed `Float` value instead of the primitive `float` so that the native code can decide what value to use by default (`LayoutParams.MATCH_PARENT` in this case).

Reviewed By: rickhanlonii

Differential Revision: D17343172

fbshipit-source-id: 7662a4e0e495f58d05a92892f063535a359d09ae

2019-09-23 07:18:09 -07:00

buck_tests

Allow null as default value for float props

2019-09-23 07:18:09 -07:00

e2e/__test_fixtures__

Allow null as default value for float props

2019-09-23 07:18:09 -07:00

src

Allow null as default value for float props

2019-09-23 07:18:09 -07:00

BUCK

Add tests for comparing old and new codegen