mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
ae756647c9
Summary:
It is possible that `init` is null when using the following code.
```js
export var a;
```
The typescript compiler actually generates something like this for enums so a lot of third party libraries triggered this issue.
For example in expo-apple-authentication/build/AppleAuthentication.types.js
```js
export var AppleAuthenticationScope;
(function (AppleAuthenticationScope) {
AppleAuthenticationScope[AppleAuthenticationScope["FULL_NAME"] = 0] = "FULL_NAME";
AppleAuthenticationScope[AppleAuthenticationScope["EMAIL"] = 1] = "EMAIL";
})(AppleAuthenticationScope || (AppleAuthenticationScope = {}));
```
This simply adds a null check.
## Changelog
[General] [Fixed] - Fix babel-plugin-codegen crash when export init is null
Pull Request resolved: https://github.com/facebook/react-native/pull/33387
Test Plan: Tested that this fixed the crash in an app.
Reviewed By: javache
Differential Revision: D34687271
Pulled By: philIip
fbshipit-source-id: 7a7e0fe1bb6a7a21a5b442af26b221a263d4173d
153 lines
4.4 KiB
JavaScript
153 lines
4.4 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
let flow, RNCodegen;
|
|
|
|
const {basename} = require('path');
|
|
|
|
try {
|
|
flow = require('react-native-codegen/src/parsers/flow');
|
|
RNCodegen = require('react-native-codegen/src/generators/RNCodegen');
|
|
} catch (e) {
|
|
// Fallback to lib when source doesn't exit (e.g. when installed as a dev dependency)
|
|
flow = require('react-native-codegen/lib/parsers/flow');
|
|
RNCodegen = require('react-native-codegen/lib/generators/RNCodegen');
|
|
}
|
|
|
|
function generateViewConfig(filename, code) {
|
|
const schema = flow.parseString(code);
|
|
|
|
const libraryName = basename(filename).replace(/NativeComponent\.js$/, '');
|
|
return RNCodegen.generateViewConfig({
|
|
schema,
|
|
libraryName,
|
|
});
|
|
}
|
|
|
|
function isCodegenDeclaration(declaration) {
|
|
if (!declaration) {
|
|
return false;
|
|
}
|
|
|
|
if (
|
|
declaration.left &&
|
|
declaration.left.left &&
|
|
declaration.left.left.name === 'codegenNativeComponent'
|
|
) {
|
|
return true;
|
|
} else if (
|
|
declaration.callee &&
|
|
declaration.callee.name &&
|
|
declaration.callee.name === 'codegenNativeComponent'
|
|
) {
|
|
return true;
|
|
} else if (
|
|
declaration.type === 'TypeCastExpression' &&
|
|
declaration.expression &&
|
|
declaration.expression.callee &&
|
|
declaration.expression.callee.name &&
|
|
declaration.expression.callee.name === 'codegenNativeComponent'
|
|
) {
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
}
|
|
|
|
module.exports = function ({parse, types: t}) {
|
|
return {
|
|
pre(state) {
|
|
this.code = state.code;
|
|
this.filename = state.opts.filename;
|
|
this.defaultExport = null;
|
|
this.commandsExport = null;
|
|
this.codeInserted = false;
|
|
},
|
|
visitor: {
|
|
ExportNamedDeclaration(path) {
|
|
if (this.codeInserted) {
|
|
return;
|
|
}
|
|
|
|
if (
|
|
path.node.declaration &&
|
|
path.node.declaration.declarations &&
|
|
path.node.declaration.declarations[0]
|
|
) {
|
|
const firstDeclaration = path.node.declaration.declarations[0];
|
|
|
|
if (firstDeclaration.type === 'VariableDeclarator') {
|
|
if (
|
|
firstDeclaration.init &&
|
|
firstDeclaration.init.type === 'CallExpression' &&
|
|
firstDeclaration.init.callee.type === 'Identifier' &&
|
|
firstDeclaration.init.callee.name === 'codegenNativeCommands'
|
|
) {
|
|
if (
|
|
firstDeclaration.id.type === 'Identifier' &&
|
|
firstDeclaration.id.name !== 'Commands'
|
|
) {
|
|
throw path.buildCodeFrameError(
|
|
"Native commands must be exported with the name 'Commands'",
|
|
);
|
|
}
|
|
this.commandsExport = path;
|
|
return;
|
|
} else {
|
|
if (firstDeclaration.id.name === 'Commands') {
|
|
throw path.buildCodeFrameError(
|
|
"'Commands' is a reserved export and may only be used to export the result of codegenNativeCommands.",
|
|
);
|
|
}
|
|
}
|
|
}
|
|
} else if (path.node.specifiers && path.node.specifiers.length > 0) {
|
|
path.node.specifiers.forEach(specifier => {
|
|
if (
|
|
specifier.type === 'ExportSpecifier' &&
|
|
specifier.local.type === 'Identifier' &&
|
|
specifier.local.name === 'Commands'
|
|
) {
|
|
throw path.buildCodeFrameError(
|
|
"'Commands' is a reserved export and may only be used to export the result of codegenNativeCommands.",
|
|
);
|
|
}
|
|
});
|
|
}
|
|
},
|
|
ExportDefaultDeclaration(path, state) {
|
|
if (isCodegenDeclaration(path.node.declaration)) {
|
|
this.defaultExport = path;
|
|
}
|
|
},
|
|
|
|
Program: {
|
|
exit(path) {
|
|
if (this.defaultExport) {
|
|
const viewConfig = generateViewConfig(this.filename, this.code);
|
|
this.defaultExport.replaceWithMultiple(
|
|
parse(viewConfig, {
|
|
babelrc: false,
|
|
browserslistConfigFile: false,
|
|
configFile: false,
|
|
}).program.body,
|
|
);
|
|
if (this.commandsExport != null) {
|
|
this.commandsExport.remove();
|
|
}
|
|
this.codeInserted = true;
|
|
}
|
|
},
|
|
},
|
|
},
|
|
};
|
|
};
|