mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Andrei Shikov
1953f6f02e
Summary: With the `MapBuffer`-based props calculated from C++ props, there's no need to keep `rawProps` around for Android views. This change makes sure that the `rawProps` field is only initialized under the feature flag that is responsible for enabling `MapBuffer` for prop diffing, potentially decreasing memory footprint and speeding up node initialization as JS props don't have to be converted to `folly::dynamic` anymore. For layout animations, props rely on C++ values, so there's no need to update `rawProps` values either. Changelog: [Internal][Android] - Do not init `rawProps` when mapbuffer serialization is used for ViewProps. Reviewed By: mdvacca Differential Revision: D33793044 fbshipit-source-id: 35873b10d3ca8b152b25344ef2c27aff9641846f
58 lines
2.1 KiB
C++
58 lines
2.1 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <react/renderer/components/view/ViewProps.h>
|
|
#include <react/renderer/graphics/Transform.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
/**
|
|
* Given animation progress, old props, new props, and an "interpolated" shared
|
|
* props struct, this will mutate the "interpolated" struct in-place to give it
|
|
* values interpolated between the old and new props.
|
|
*/
|
|
static inline void interpolateViewProps(
|
|
Float animationProgress,
|
|
const SharedProps &oldPropsShared,
|
|
const SharedProps &newPropsShared,
|
|
SharedProps &interpolatedPropsShared) {
|
|
ViewProps const *oldViewProps =
|
|
static_cast<ViewProps const *>(oldPropsShared.get());
|
|
ViewProps const *newViewProps =
|
|
static_cast<ViewProps const *>(newPropsShared.get());
|
|
ViewProps *interpolatedProps = const_cast<ViewProps *>(
|
|
static_cast<ViewProps const *>(interpolatedPropsShared.get()));
|
|
|
|
interpolatedProps->opacity = oldViewProps->opacity +
|
|
(newViewProps->opacity - oldViewProps->opacity) * animationProgress;
|
|
|
|
interpolatedProps->transform = Transform::Interpolate(
|
|
animationProgress, oldViewProps->transform, newViewProps->transform);
|
|
|
|
// Android uses RawProps, not props, to update props on the platform...
|
|
// Since interpolated props don't interpolate at all using RawProps, we need
|
|
// to "re-hydrate" raw props after interpolating. This is what actually gets
|
|
// sent to the mounting layer. This is a temporary hack, only for platforms
|
|
// that use RawProps/folly::dynamic instead of concrete props on the
|
|
// mounting layer. Once we can remove this, we should change `rawProps` to
|
|
// be const again.
|
|
#ifdef ANDROID
|
|
if (!interpolatedProps->rawProps.isNull()) {
|
|
interpolatedProps->rawProps["opacity"] = interpolatedProps->opacity;
|
|
|
|
interpolatedProps->rawProps["transform"] =
|
|
(folly::dynamic)interpolatedProps->transform;
|
|
}
|
|
#endif
|
|
}
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|