mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/52446 The logic for retrieving metrics from a placeholder character is kind of insane, and has been around since inline views were added built into TextView in Paper. One of the workarounds, for old versions of Android on Samsung phones (no more info to bound the versions) causes incorrect behavior, at least in the case where we have RTL text in LTR layout. Another, explicitly mentions `singleLine` with RTL para, a deprecated TextView prop, that doesn't apply to us here (and also could never apply to BoringLayout, since RTL chars are not boring). We don't have these workarounds anywhere else (though we have some other workarounds for bidi crash in old Android), including other frameworks I could find. Let's bias to cleaning this old code up. Changelog: [Android][Fixed] - Fix incorrect positioning of inline view at the end of string when RTL text in LTR container Reviewed By: javache Differential Revision: D77703906 fbshipit-source-id: f25a5e2f05100f0288f3889132b658cdabf26f22