mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Janic Duplessis
b2cf24f41c
Summary: I've been seeing a couple crashes related to missing hermes-executor-common.so, seems to happen on specific android versions, but can't repro. I investigated this so file more and noticed it is incorrectly linked as a static library here https://github.com/facebook/react-native/blob/b8f415eb6cdc0e0e7a7413b6f9defdcee304d9e8/ReactAndroid/src/main/java/com/facebook/hermes/reactexecutor/Android.mk#L20. There doesn't seem to be any reason for this to be a shared lib so I changed it to be compiled as a static lib. ## Changelog [Android] [Fixed] - Make hermes-executor-common a static lib Pull Request resolved: https://github.com/facebook/react-native/pull/32683 Test Plan: - Verify there is no more hermes-executor-common-{release,debug}.so - Test locally in an app to make sure it build and run properly. - Verify that the crash happening on play store pre-launch report doesn't happen anymore. Reviewed By: ShikaSD Differential Revision: D32754968 Pulled By: cortinico fbshipit-source-id: cb57e2d81edb4cbdb1f003dab45c53e594a5a62a
38 lines
1.2 KiB
Makefile
38 lines
1.2 KiB
Makefile
# Copyright (c) Facebook, Inc. and its affiliates.
|
|
#
|
|
# This source code is licensed under the MIT license found in the
|
|
# LICENSE file in the root directory of this source tree.
|
|
|
|
LOCAL_PATH := $(call my-dir)
|
|
REACT_NATIVE := $(LOCAL_PATH)/../../..
|
|
|
|
include $(REACT_NATIVE)/ReactCommon/common.mk
|
|
include $(CLEAR_VARS)
|
|
|
|
LOCAL_MODULE := hermes-executor-common-release
|
|
|
|
LOCAL_SRC_FILES := $(wildcard $(LOCAL_PATH)/*.cpp)
|
|
|
|
LOCAL_C_INCLUDES := $(LOCAL_PATH) $(REACT_NATIVE)/ReactCommon/jsi $(call find-node-module,$(LOCAL_PATH),hermes-engine)/android/include
|
|
LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)
|
|
|
|
LOCAL_STATIC_LIBRARIES := libjsireact
|
|
LOCAL_SHARED_LIBRARIES := libhermes libjsi
|
|
|
|
include $(BUILD_STATIC_LIBRARY)
|
|
|
|
include $(CLEAR_VARS)
|
|
|
|
LOCAL_MODULE := hermes-executor-common-debug
|
|
LOCAL_CFLAGS := -DHERMES_ENABLE_DEBUGGER=1
|
|
|
|
LOCAL_SRC_FILES := $(wildcard $(LOCAL_PATH)/*.cpp)
|
|
|
|
LOCAL_C_INCLUDES := $(LOCAL_PATH) $(REACT_NATIVE)/ReactCommon/jsi $(call find-node-module,$(LOCAL_PATH),hermes-engine)/android/include
|
|
LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)
|
|
|
|
LOCAL_STATIC_LIBRARIES := libjsireact libhermes-inspector
|
|
LOCAL_SHARED_LIBRARIES := libhermes libjsi
|
|
|
|
include $(BUILD_STATIC_LIBRARY)
|