mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Nick Gerleman
9aae84a688
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48054 Web debugging should be fully removed as of recent, so lets remove some of the gunk that was powering it, and checks for that environment. I did some string searches for the following: * isAsyncDebugging * debugRemotely * isDebuggingRemotely * isRemoteDebuggingAvailable * WebSocketExecutor * JavaJSExecutor * ProxyJavaScriptExecutor * RELOAD_APP_EXTRA_JS_PROXY * getJSBundleURLForRemoteDebugging * onReloadWithJSDebugger * setRemoteJSDebugEnabled * WebsocketJavaScriptExecutor * createRemoteDebuggerBundleLoader 1. `expo-modules-core` exposes its own `isAsyncDebugging` by checking for `nativeCallSyncHook`, but does not depend on `DebugEnvironment`. 2. `expo-dev-menu` does read `isDebuggingRemotely` from `DevSettings`. 3. Realm does a check in Native using `objc_lookUpClass("RCTWebSocketExecutor")` but will gracefully handle `nil` if it does not exist 4. Some more usages (e.g. `onReloadWithJSDebugger`) in vendored packages of `expo-dev-launcher` for RN 0.74 I created an issue for Expo mentioning both here: https://github.com/expo/expo/issues/33371 Changelog: [General][Breaking] - Remove some web debugging remnants Reviewed By: huntie Differential Revision: D66553934 fbshipit-source-id: deec382b1c8bda393fddb8682aa91b26afd9fbe3