mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Andrew Coates
4d87d8c6b2
Summary: react-native-windows runs with a more strict set of warnings as errors. This fixes a bunch of warnings being hit while compiling core react-native code as part of react-native-windows. In particular warnings about mismatched signed/unsigned comparisons, lossy conversions, and variable names that conflict with names in outer scopes (yoga has a global for `leading` and `trailing` that conflicts with some local variable names) ## Changelog [Internal] [Fixed] - Fix various C++ warnings Pull Request resolved: https://github.com/facebook/react-native/pull/31399 Test Plan: I've run these changes in react-native-windows. -- Shouldn't have any functionality difference. Reviewed By: sammy-SC Differential Revision: D28290188 Pulled By: rozele fbshipit-source-id: 2f7cf87f58d73a3f43510ac888dbcb9ab177d134
119 lines
3.2 KiB
C++
119 lines
3.2 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "EventEmitter.h"
|
|
|
|
#include <folly/dynamic.h>
|
|
#include <jsi/JSIDynamic.h>
|
|
#include <jsi/jsi.h>
|
|
#include <react/renderer/debug/SystraceSection.h>
|
|
|
|
#include "RawEvent.h"
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
// TODO(T29874519): Get rid of "top" prefix once and for all.
|
|
/*
|
|
* Capitalizes the first letter of the event type and adds "top" prefix if
|
|
* necessary (e.g. "layout" becames "topLayout").
|
|
*/
|
|
static std::string normalizeEventType(const std::string &type) {
|
|
auto prefixedType = type;
|
|
if (type.find("top", 0) != 0) {
|
|
prefixedType.insert(0, "top");
|
|
prefixedType[3] = static_cast<char>(toupper(prefixedType[3]));
|
|
}
|
|
return prefixedType;
|
|
}
|
|
|
|
std::mutex &EventEmitter::DispatchMutex() {
|
|
static std::mutex mutex;
|
|
return mutex;
|
|
}
|
|
|
|
ValueFactory EventEmitter::defaultPayloadFactory() {
|
|
static auto payloadFactory =
|
|
ValueFactory{[](jsi::Runtime &runtime) { return jsi::Object(runtime); }};
|
|
return payloadFactory;
|
|
}
|
|
|
|
EventEmitter::EventEmitter(
|
|
SharedEventTarget eventTarget,
|
|
Tag tag,
|
|
EventDispatcher::Weak eventDispatcher)
|
|
: eventTarget_(std::move(eventTarget)),
|
|
eventDispatcher_(std::move(eventDispatcher)) {}
|
|
|
|
void EventEmitter::dispatchEvent(
|
|
const std::string &type,
|
|
const folly::dynamic &payload,
|
|
EventPriority priority) const {
|
|
dispatchEvent(
|
|
type,
|
|
[payload](jsi::Runtime &runtime) {
|
|
return valueFromDynamic(runtime, payload);
|
|
},
|
|
priority);
|
|
}
|
|
|
|
void EventEmitter::dispatchEvent(
|
|
const std::string &type,
|
|
const ValueFactory &payloadFactory,
|
|
EventPriority priority) const {
|
|
SystraceSection s("EventEmitter::dispatchEvent");
|
|
|
|
auto eventDispatcher = eventDispatcher_.lock();
|
|
if (!eventDispatcher) {
|
|
return;
|
|
}
|
|
|
|
eventDispatcher->dispatchEvent(
|
|
RawEvent(normalizeEventType(type), payloadFactory, eventTarget_),
|
|
priority);
|
|
}
|
|
|
|
void EventEmitter::dispatchUniqueEvent(
|
|
const std::string &type,
|
|
const ValueFactory &payloadFactory) const {
|
|
SystraceSection s("EventEmitter::dispatchUniqueEvent");
|
|
|
|
auto eventDispatcher = eventDispatcher_.lock();
|
|
if (!eventDispatcher) {
|
|
return;
|
|
}
|
|
|
|
eventDispatcher->dispatchUniqueEvent(
|
|
RawEvent(normalizeEventType(type), payloadFactory, eventTarget_));
|
|
}
|
|
|
|
void EventEmitter::setEnabled(bool enabled) const {
|
|
enableCounter_ += enabled ? 1 : -1;
|
|
|
|
bool shouldBeEnabled = enableCounter_ > 0;
|
|
if (isEnabled_ != shouldBeEnabled) {
|
|
isEnabled_ = shouldBeEnabled;
|
|
if (eventTarget_) {
|
|
eventTarget_->setEnabled(isEnabled_);
|
|
}
|
|
}
|
|
|
|
// Note: Initially, the state of `eventTarget_` and the value `enableCounter_`
|
|
// is mismatched intentionally (it's `non-null` and `0` accordingly). We need
|
|
// this to support an initial nebula state where the event target must be
|
|
// retained without any associated mounted node.
|
|
bool shouldBeRetained = enableCounter_ > 0;
|
|
if (shouldBeRetained != (eventTarget_ != nullptr)) {
|
|
if (!shouldBeRetained) {
|
|
eventTarget_.reset();
|
|
}
|
|
}
|
|
}
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|