Files
react-native/ReactCommon/react/renderer/core/EventDispatcher.cpp
T
Samuel Susla ffa533a19d Add option to use unbatched queues only
Summary:
Changelog: [internal]

My suggestion is to simplify event dispatching to only two options, synchronous and asynchronous.

Why?
- Fabric has only been using one queue, `AsynchronousBatched`.
- Batching happens even on `AsynchronousUnbatched`. It just batches events until JS thread starts processing them instead of waiting for the main run loop.
- It will make it easier to reason about the code in the future once we start utilising different priorities for Concurrent Mode.

Reviewed By: JoshuaGross

Differential Revision: D28603472

fbshipit-source-id: 14e3a9c15a012c550dc16a044c31d722051a2bdc
2021-05-22 12:19:05 -07:00

91 lines
2.9 KiB
C++

/*
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#include "EventDispatcher.h"
#include <react/renderer/core/StateUpdate.h>
#include "BatchedEventQueue.h"
#include "RawEvent.h"
#include "UnbatchedEventQueue.h"
namespace facebook {
namespace react {
EventDispatcher::EventDispatcher(
EventPipe const &eventPipe,
StatePipe const &statePipe,
EventBeat::Factory const &synchonousEventBeatFactory,
EventBeat::Factory const &asynchonousEventBeatFactory,
EventBeat::SharedOwnerBox const &ownerBox,
bool unbatchedQueuesOnly)
: synchronousUnbatchedQueue_(std::make_unique<UnbatchedEventQueue>(
eventPipe,
statePipe,
synchonousEventBeatFactory(ownerBox))),
synchronousBatchedQueue_(std::make_unique<BatchedEventQueue>(
eventPipe,
statePipe,
synchonousEventBeatFactory(ownerBox))),
asynchronousUnbatchedQueue_(std::make_unique<UnbatchedEventQueue>(
eventPipe,
statePipe,
asynchonousEventBeatFactory(ownerBox))),
asynchronousBatchedQueue_(std::make_unique<BatchedEventQueue>(
eventPipe,
statePipe,
asynchonousEventBeatFactory(ownerBox))),
unbatchedQueuesOnly_(unbatchedQueuesOnly) {}
void EventDispatcher::dispatchEvent(RawEvent &&rawEvent, EventPriority priority)
const {
getEventQueue(priority).enqueueEvent(std::move(rawEvent));
}
void EventDispatcher::dispatchStateUpdate(
StateUpdate &&stateUpdate,
EventPriority priority) const {
getEventQueue(priority).enqueueStateUpdate(std::move(stateUpdate));
}
void EventDispatcher::dispatchUniqueEvent(RawEvent &&rawEvent) const {
if (unbatchedQueuesOnly_) {
asynchronousUnbatchedQueue_->enqueueUniqueEvent(std::move(rawEvent));
} else {
asynchronousBatchedQueue_->enqueueUniqueEvent(std::move(rawEvent));
}
}
const EventQueue &EventDispatcher::getEventQueue(EventPriority priority) const {
if (unbatchedQueuesOnly_) {
switch (priority) {
case EventPriority::SynchronousUnbatched:
return *synchronousUnbatchedQueue_;
case EventPriority::SynchronousBatched:
return *synchronousUnbatchedQueue_;
case EventPriority::AsynchronousUnbatched:
return *asynchronousUnbatchedQueue_;
case EventPriority::AsynchronousBatched:
return *asynchronousUnbatchedQueue_;
}
} else {
switch (priority) {
case EventPriority::SynchronousUnbatched:
return *synchronousUnbatchedQueue_;
case EventPriority::SynchronousBatched:
return *synchronousBatchedQueue_;
case EventPriority::AsynchronousUnbatched:
return *asynchronousUnbatchedQueue_;
case EventPriority::AsynchronousBatched:
return *asynchronousBatchedQueue_;
}
}
}
} // namespace react
} // namespace facebook