react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Samuel Susla 7a01afe03b Remove LayoutInspectingPolicy.includeScrollViewContentOffset

Summary:
`LayoutInspectingPolicy` has two flags, `includeTransform` and `includeScrollViewContentOffset`.

`includeScrollViewContentOffset` seems to be redundant for two reasons.

# 1st
From looking at callers, they have always the same value.
I looked at all call sites, and they are either always both set to true or both set to false.

# 2nd
The way we include scroll view content offset, is through transformation, so setting `includeTransform` to true and `includeScrollViewContentOffset` to false will include content offset anyway. In order to make both flags work, we would need to introduce further changes to `getRelativeLayoutMetrics`. But since the flag isn't used anyway, I think it is better to get rid of it for now. If we need it in the future, we could re-introduce it.

Reviewed By: shergin

Differential Revision: D20622256

fbshipit-source-id: fb6156c66b752319ea928239fa723ff90688b0a0

2020-03-30 04:03:57 -07:00

better

Replace fbsource// with // in xplat/js/ files [1]

2020-03-25 21:55:47 -07:00

callinvoker

make RN infra labels public

2020-02-28 12:46:49 -08:00

config

Replace fbsource// with // in xplat/js/ files [1]

2020-03-25 21:55:47 -07:00

cxxreact

Replace fbsource// with // in xplat/js/ files [1]