Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
794aaa52d39f2c419fcd49126c69dff3030e7bb9
react-native/packages/react-native-popup-menu-android/android/src
T
History
Alan Lee 47c6311422 fix issue with PopupMenuAndroid event (#44103) 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/44103

Changes here fixes events in PopupMenuAndroid not being triggered correctly.

Issuses were:
1) naming mismatch
2) wrong parameters were set for the Event Map
3) missing code in .cpp

Applied fixes:
1) consistent event naming
2) fixed key used for event mapping
3) re-ran codegen to update .cpp files

## Changelog:

[Android] [internal] - Fix issue with PopupMenuAndroid event callback not working

Steps took to run codegen for this diff: https://www.internalfb.com/intern/phabricator/paste/markdown/P1214671854/

This diff is patching issues from D55531870

Reviewed By: RSNara

Differential Revision: D56164235

fbshipit-source-id: 4cf66ad3cfd753c146c5e219f27910834731e183
2024-04-16 00:27:57 -07:00
..
jni/react/renderer/components/ReactPopupMenuAndroidSpecs
fix issue with PopupMenuAndroid event (#44103)
2024-04-16 00:27:57 -07:00
main/java/com/facebook/react
fix issue with PopupMenuAndroid event (#44103)
2024-04-16 00:27:57 -07:00